From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by sourceware.org (Postfix) with ESMTPS id B85C03858C2D for ; Tue, 11 Oct 2022 06:01:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B85C03858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=martin.st Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=martin.st Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 29B61qli009861-29B61qlj009861; Tue, 11 Oct 2022 09:01:52 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 323E6A1437; Tue, 11 Oct 2022 09:01:52 +0300 (EEST) Date: Tue, 11 Oct 2022 09:01:49 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Mark Harmstone cc: binutils@sourceware.org Subject: Re: [PATCH v3 1/2] ld: Add --pdb option In-Reply-To: <20221011003702.4287-1-mark@harmstone.com> Message-ID: References: <20221011003702.4287-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-421128676-1665468112=:1659" X-FE-Attachment-Name: 0001-squash-ld-Fix-writing-PDB-files-with-an-implicit-nam.patch X-FE-Policy-ID: 3:14:2:SYSTEM X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-421128676-1665468112=:1659 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 11 Oct 2022, Mark Harmstone wrote: > Resubmission including Martin Storsjö's amendments > (https://sourceware.org/pipermail/binutils/2022-October/123470.html), to > match the behaviour of lld. Thanks! Options parsing wise, this works correctly now, but the moved code for setting emit_build_id broke actually generating a PDB file with an implicit name. The attached patch fixes that. // Martin --8323329-421128676-1665468112=:1659 Content-Type: text/x-diff; name=0001-squash-ld-Fix-writing-PDB-files-with-an-implicit-nam.patch Content-Transfer-Encoding: BASE64 Content-ID: <63c1309-76a0-31f9-643a-defcb873a94f@martin.st> Content-Description: Content-Disposition: attachment; filename=0001-squash-ld-Fix-writing-PDB-files-with-an-implicit-nam.patch RnJvbSA5Y2ZhMTY5MTcxNGM0NDk5MWZjMDQ5MjdiODViOGIxNzc2NGJmMzg4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogPT9VVEYtOD9xP01h cnRpbj0yMFN0b3Jzaj1DMz1CNj89IDxtYXJ0aW5AbWFydGluLnN0Pg0KRGF0 ZTogVHVlLCAxMSBPY3QgMjAyMiAwODo1OTo0MiArMDMwMA0KU3ViamVjdDog W1BBVENIXSBzcXVhc2g6IGxkOiBGaXggd3JpdGluZyBQREIgZmlsZXMgd2l0 aCBhbiBpbXBsaWNpdCBuYW1lDQoNCi0tLQ0KIGxkL2VtdWx0ZW1wbC9wZS5l bSAgfCAyICstDQogbGQvZW11bHRlbXBsL3BlcC5lbSB8IDIgKy0NCiAyIGZp bGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkN Cg0KZGlmZiAtLWdpdCBhL2xkL2VtdWx0ZW1wbC9wZS5lbSBiL2xkL2VtdWx0 ZW1wbC9wZS5lbQ0KaW5kZXggMjAyZTgwODk4ZGIuLjkwNzI1OTUzNWI3IDEw MDY0NA0KLS0tIGEvbGQvZW11bHRlbXBsL3BlLmVtDQorKysgYi9sZC9lbXVs dGVtcGwvcGUuZW0NCkBAIC0xMTA2LDcgKzExMDYsNyBAQCBnbGQke0VNVUxB VElPTl9OQU1FfV9hZnRlcl9wYXJzZSAodm9pZCkNCiAgICAgZWluZm8gKF8o IiVQOiB3YXJuaW5nOiAtLWV4cG9ydC1keW5hbWljIGlzIG5vdCBzdXBwb3J0 ZWQgZm9yIFBFICINCiAgICAgICAidGFyZ2V0cywgZGlkIHlvdSBtZWFuIC0t ZXhwb3J0LWFsbC1zeW1ib2xzP1xuIikpOw0KIA0KLSAgaWYgKHBkYl9uYW1l ICYmIGVtaXRfYnVpbGRfaWQgPT0gTlVMTCkNCisgIGlmIChwZGIgJiYgZW1p dF9idWlsZF9pZCA9PSBOVUxMKQ0KICAgICBlbWl0X2J1aWxkX2lkID0geHN0 cmR1cCAoREVGQVVMVF9CVUlMRF9JRF9TVFlMRSk7DQogDQogICBzZXRfZW50 cnlfcG9pbnQgKCk7DQpkaWZmIC0tZ2l0IGEvbGQvZW11bHRlbXBsL3BlcC5l bSBiL2xkL2VtdWx0ZW1wbC9wZXAuZW0NCmluZGV4IDYzODFlYWQ5MDIxLi42 NzI4MDYzMTUyOCAxMDA2NDQNCi0tLSBhL2xkL2VtdWx0ZW1wbC9wZXAuZW0N CisrKyBiL2xkL2VtdWx0ZW1wbC9wZXAuZW0NCkBAIC0xMDQ5LDcgKzEwNDks NyBAQCBnbGQke0VNVUxBVElPTl9OQU1FfV9hZnRlcl9wYXJzZSAodm9pZCkN CiAgICAgZWluZm8gKF8oIiVQOiB3YXJuaW5nOiAtLWV4cG9ydC1keW5hbWlj IGlzIG5vdCBzdXBwb3J0ZWQgZm9yIFBFKyAiDQogICAgICAgInRhcmdldHMs IGRpZCB5b3UgbWVhbiAtLWV4cG9ydC1hbGwtc3ltYm9scz9cbiIpKTsNCiAN Ci0gIGlmIChwZGJfbmFtZSAmJiBlbWl0X2J1aWxkX2lkID09IE5VTEwpDQor ICBpZiAocGRiICYmIGVtaXRfYnVpbGRfaWQgPT0gTlVMTCkNCiAgICAgZW1p dF9idWlsZF9pZCA9IHhzdHJkdXAgKERFRkFVTFRfQlVJTERfSURfU1RZTEUp Ow0KIA0KICAgc2V0X2VudHJ5X3BvaW50ICgpOw0KLS0gDQoyLjI1LjENCg0K --8323329-421128676-1665468112=:1659--