From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by sourceware.org (Postfix) with ESMTPS id CE750382EA1E for ; Thu, 27 Oct 2022 07:15:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE750382EA1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mE8N0iatT5l2AJbrze2ABZLH25ht/89xz/RI+VpIRcvk0P4UDl6pGV/yO65K8qC8tPQbTlcBHwzbq7lAtNpjn2f9E2sI4bA1vnYQxu2hL2Xj6MBdDb7zgvjTI72adWhUaNDUclXRxnd7FwJ/zVodbyG+SqRMkg0GKYs7N/6rqMkWzCOHh9IMYP4lffdaMv93jAmZ/ZZjCAWCVxQjL/rgre0k4uD3GZ4HIMpw8a8OBgcbVKjxMD/Jnz13KhRxBxRs14p0hBxLbpOSso5i6YEBDzuCoKKMmxlWgonOtyclMDE8pEn1x+7QEQrYFpowH8Os2rx/9UhqYE/K16HqvRwILQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YW9/Y20PVSgMO9hFlZbteKTePWaAxcJp+9rPkKZyr7E=; b=dgZuJIze9TXIrDU5PwjFPXwicCafyf7Od8u171FpKDoZE4Vyzuk+pwjAjStFTzi+UoAfhoU3OzxyEBTO3lgDQxqhISjuugsqsICqIGpcwP413IBeKZtJMFRmNJ5CHE7Nidw2xWwb5Pc0zRnyqfSYajdzSjQVCoIoTwz0BFSo4fWgzWM82snnN9qx/BZAdwq2rnLxyQZivcw1LWz9mCyqGy1T9y/NIm7XwuaIo7HW9bJqr6eQhplKcNMKJ+0wnyUq5dj0Ui8weANj9DjCTKOHcIHhptHjwQh+11yqDsohg4RV8zs11mV8v41PPOeHlOHja7NkW/gMz5nTKzaL2p4xtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YW9/Y20PVSgMO9hFlZbteKTePWaAxcJp+9rPkKZyr7E=; b=fZm3LeJke+bgnOKRGQklyVxUC0nAohZOQhekxMZGitFsZSo1V8jzeLGFOuaB4Wz5gHxi11wnpCpvZlnekl18gMgDxbap7JqIDAdQWWJuBPSao7Qqd5UN8k0p+aNFprX8E/GaI22OYzSnJa+hUrSbGTAKub0ryRZoP1tw8uRHWrh1pu8HnwvDV2gfvO9R/AAT0oj9e2fbsUog4NwFqJ8JyZDd4Fex1dfBAP4lkbgAOl0Z//961KUKignLRJzPY34OTBHfi/kbhCHHqYbDgiyE9apSQnXeYV75ySCvMCLzfQhUC86C1W8schLJmszkcrgCl/KLD4JfDWqvPK3VOlVc9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8480.eurprd04.prod.outlook.com (2603:10a6:10:2c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct 2022 07:15:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022 07:15:31 +0000 Message-ID: Date: Thu, 27 Oct 2022 09:15:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 10/10] Support Intel PREFETCHI Content-Language: en-US To: "Cui, Lili" Cc: "binutils@sourceware.org" , "Jiang, Haochen" , "H.J. Lu" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-11-haochen.jiang@intel.com> <0aa4d551-e9ab-5e09-4f94-c672b7724915@suse.com> <9f7cfcd0-36aa-91d0-dfd6-462b69c41ac7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0097.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8480:EE_ X-MS-Office365-Filtering-Correlation-Id: 417bee0d-b02e-4b96-55cb-08dab7eb0830 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WcKUy0XRC47KeXJOSLMVpLeOgcBmWqLicbBHq8nuxvnEY5wqvWotPDD1eMiGjYElCu69186jGxuc0KhJ+ErmmVWvvw9PF/rjoJTvbIYfpmjSQYjn+Hijg4QdG4VNuH935lzK2OINvGmNWrB+LqFQ0d5MHO6Rw3lwL9GYK4hMdKb/xjhVfPWqSLPkEpT0P1ZWr3gJMzoldNML4jYOs04BrlaeDsyV4mwBmt5MbVgDd49p+lc9SR3zASEK0AQgsqv2qfPRud1awPOysCj/kviCrVCGGK+q+QpRvui3YZSljVNdGbVuVAU3SjaHtsInhqcDlLiU1BFpszD/fOQQ57KnekFxH27+TGpF3UD18jDMIQBeeGU/+HSO1+OBqT90n4yg7blDoYixWhuDjL5AQ/kfZciCUd4sZ/eXg7ARCwDosF4sJP1+Q6EQzefCg0jRWYNopdTNt8XnQ2QrdvMKIY1RNhlEPaSvFKRUn0TaNC/MbgG4HSu+bY+euiqcx8pvRKGV1BzHkpLSX34qpd1qiWHqfsa3wl2jgczGUSalRPy1tpzwBYt3/4e7hFMh8BI61UVm2nIeQmGEpczAqDJj0oMk0YqNs9h44sQFe/kjziVx6xURf3fZQ1ZcjCjmc+QNtPWRCE0CQveb/lGMZzxRp1rh2RiUrfCv9NedlZY2Pf7WZ8bclz432cpP767ildTtqACSYIAgT855O30rQtYOneXqleaYi/T+7o2ECx01rTHLz23C9e7wbMjbBe9qiYPBmX7GX5oHx2QnKRbl4VgqlkMfu+FWs8B+mwPCVXU53QH+9fpzDvl2zcMk4x4aEC0prM9h X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(66946007)(8676002)(4326008)(66556008)(66476007)(316002)(6916009)(2906002)(54906003)(38100700002)(8936002)(5660300002)(41300700001)(36756003)(6506007)(186003)(2616005)(6512007)(26005)(53546011)(6486002)(478600001)(31696002)(83380400001)(86362001)(31686004)(223384002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekwzRTdnVmdDTm1IMzJOaWpEeTE1MTM3bXdKSzRQajRnWWlvZmRKRE1tbVlw?= =?utf-8?B?c0pvOHp0OUNsdy9mZ3A2Q2VDbjRPTEx2cnp1R3h2R2tTdEIyK1lJQ0o4OHB4?= =?utf-8?B?a3FDOUZLbE9TL2JXV0JDdXBiNUJzTE9HNlZ3dFdUL3Jtb2NwQXZYbDBHaXVU?= =?utf-8?B?VlN2MlowMXNCRTVjUGd3b2RNbXBZL2Y4SVpuQkpKaFF3Ulk5d3R3MXdZRXdh?= =?utf-8?B?SFErMzhmRkFrZ09NUjhhcDg2Uk9JektuQTJIaGZoYnV4aVhkQ29KV3I5M3lD?= =?utf-8?B?bjlkNVBYWVVMSDdMdStXVDhFczZuNWVENUFhWGM4NEV3OU10azQrWXhFN09j?= =?utf-8?B?cUdJUUY0ZGxRd1hpVGY4dXpGYTVpNnNHKzVBaGdTakp3VW95dnpERldBemhB?= =?utf-8?B?VG1VR0s3RTFpYUZWSGpmZ0tEbkpGWFdnakpnMG8wWi9SQWhkYllyNXhRTGov?= =?utf-8?B?dWRkUVpFZG45dzFwUEJXL29xS1dLRkVoNzY0MG5lMGhMOFduMFlBRnc5UUh1?= =?utf-8?B?K29JL0t5eGlaTjhEUmk0bCswWEUwdmttQnNZb3pteUp4QXVBODArTUNxaXBm?= =?utf-8?B?NkJCUlZtNHB4Tkx0TTRHY0JVMUFoMDRCellWNmIraTV1aXdYaEpZbnMwemwz?= =?utf-8?B?eUhBNGZTczY4b0tTTWJxZm50SnRzY3JvTlpGYTJhaFRxWGVVVnhENU5XVGkx?= =?utf-8?B?Y2VyUkJUZXlnSlVmZEtNd1Q3OVdyQXZWZENCamxvU3BIek8yWGlGNGJzMXFQ?= =?utf-8?B?WGtNelJFQnJTaVBMQXpVdm1PdEYwT2o4VzA0TTNPS2VoUmcyNG1ZRjRjT1Bu?= =?utf-8?B?aE9RdlVKMmN1VFB0MmVpT252THRuMXJvT2duc1dyalFCTndOcVcrY2FlZW5h?= =?utf-8?B?SzdxdTlnalFLai9GSUJxQ1RtUHgzaWJZZU1QYjNLMXNRbkx2ajZtelU1TUJQ?= =?utf-8?B?R2pSelZDd1VpWEo3ZTFuZmxZODVneWMrbDAwZ24ya1RrRWVOeGxoaHdCcEtN?= =?utf-8?B?SmVOcmQxYmlaSnoyd2ZBeXJDTnpZT0xXU2E3aEVNMk04YVlvOFhkTUNhRWRl?= =?utf-8?B?Vkd5MExqMm5iejdtUTJ1TVlUdkM4TkpENzEzUzRKcWdxVUkrcVdkUzB1M2o4?= =?utf-8?B?Y3NyYWFlYVkzZGg1d0luN1M3aHVSRXRhRTdwR21VYzVlcElWYXJlaVc5V1J3?= =?utf-8?B?cDkzQ09pZk56NjV4bTQ4bGtLeEpkWDBJaTc5VVAzSFl1UWZDaHl6OVpVZTZa?= =?utf-8?B?ellXQjh0ejQ2Z3lWNDZVcTF6YnRsUStXNzlFc2RPMWRCTit3MnhGbm55THlW?= =?utf-8?B?dDdUbHYzRXhQalMvVXh1dU5LTUJzYi9xQUFGRFllMzJLRmhzdkt1MmxyZlho?= =?utf-8?B?d1ZhS1p5MWtLK1hIbVhnNXJ2eUJFMktKRlUwMGNSYmNKQytaOE4xK2hpN2Vu?= =?utf-8?B?TWpwVzVvNWRQYnllUjdHUHZna2lqU2lTY0lNQktDRFozTWJuVHU3TW10eUhL?= =?utf-8?B?R2ZyZkVxUUYwekVJZUN5SERmT01yZHpHVFFpN05xR01FeUdVTmRaK3FCaER2?= =?utf-8?B?ZnNHSDdPa2t5dWRJeGRmWHBkeG5KcnFVM3gwQmljdTlSSi96d205LysyZTkz?= =?utf-8?B?YlQxdUZVNWo0SGlvZWZ3TDFNVHE2N05yVVNHRXNyN3Fvc0lzeW9yYUlpdWxp?= =?utf-8?B?Zi9BWVJEM2RDWkxpY3VRTFBhU1lGc0k2NGtHeFJKMEJ4Zi9FUTNXYlpwSFht?= =?utf-8?B?eXFNcWhVRFA4NWlnV0o3V2FucjlhRmx6K1M1NzIzOFM5T2pwUWRiTTV6RTY2?= =?utf-8?B?c054U3g4NTd6QTBSMmZYQ2NpZllyNk5LRG1iQzd0eTJNL05qcStQNlFGRzJw?= =?utf-8?B?S084cXB1Q3lRaXVQQW1wbHR2aENxaGwvT1NiYzYxT1hwbTBWU2xhZ2NLS0Z2?= =?utf-8?B?UTVNZUtOZStIaDFuODRQeHgrcmNZVVZ3MnhWZWM1VnM1VTVJZTBrRVFYZnpi?= =?utf-8?B?UlFicmVXN3RueGlrWTVTUU5pWkVVbWNYb0FvQUs0RmM2Q0dJV1NvcXRHS1Ny?= =?utf-8?B?Z3B4UTlZQ0V5V3l6MXJKWU0vVHFRaHdGTzk1WlkvYWthWEFaZTJ5RzZDODBw?= =?utf-8?Q?fdqw69Sv2i4b3xshJsnt8mcWe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 417bee0d-b02e-4b96-55cb-08dab7eb0830 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 07:15:31.0179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rxinogWj8ot5/CcCoN7xgtJQ/Qgseom1f47ZYBgytzx74ni5XtkE1xahJ0Tn4FNakA2g+69xIVrWJQV6Qg5hpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8480 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.10.2022 09:01, Cui, Lili wrote: >>> - /* Update operand types and check extended states. */ >>> + /* 1. Update operand types and check extended states. >>> + 2. Check IP-relative addressing for prefetchi. */ >>> for (j = 0; j < i.operands; j++) >>> { >>> + /* Check if IP-relative addressing requirements can be satisfied. */ >>> + if (i.tm.cpu_flags.bitfield.cpuprefetchi >>> + && !(i.base_reg && i.base_reg->reg_num == RegIP)) >>> + as_warn (_("only support RIP-relative address")); >> >> One final suggestion: >> >> as_warn (_("`%s' only supports RIP-relative address"), i.tm.name); >> > Done. > >> And maybe also keep code and comment in sync as to the sequence of >> things done. >> > Changed, thanks Jan. Thanks to you as well. I'd like to leave approving of the change to H.J., though. One final reminder: Please in the future send new versions of patches as new (roots of) mail threads, with an incremented version identifier. In particular when later looking for stuff, doing so often makes it easier to follow how things evolved before being committed. Jan