From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by sourceware.org (Postfix) with ESMTPS id 17E773856962 for ; Tue, 9 Aug 2022 15:05:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17E773856962 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MsQhl8JoBkBgc4d1vA3wtBnFRclxdcoC6ttm1Hv4xgHgUWkHFB0RYfG+EYO8VHTHIYEs0PKNgPQVBYhOpYSIIZTGVzbLrXuLXyAbfZqTT90kbioe+aPWePERm8o9tmM01Pgw9jE/Qzcn0YV48h22zzxiguFYtJr2KTu89hlETQhmQJrmP593jINaJxTQzaTGZn8GWznf0VdFoy6QhzmSdYdz66FjYFXUff84zSlKIS0PUpRWn4fa/EjbcI7MoTi4OrVrtr8SnNGAIedI0/4wSYi/IYCEQBoa3xFgi77TM/Tq7w7yHhE5AyeRjQOmzmrzx7DDzL0MXvLu/s7uH8p9Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hoHiw1Eg+XoTVk6C1jW55F+zXcdLMEwF5UkfAvvzEaQ=; b=JpHqq6j+uJYf22OWnBW1zmkoJrJazw7HirPvq9ByvDv+X1Gqp51/4aVnkJcx77ND2BKwPDG45Tgn0zt34XO7XI8R2/vxPMR9uzX/Y3dGQD4BRX6etpBZkvT5i0P3e/yl4JsuI4mCvgDNtHxJSU1vk/p3M0KDhgQNrf+op1UkecI8Oamlt6oQE05P0qDEkuE8hKIRfwuvJOa0o5D3cgvMOrs5ZWzHuQAMgjbGWAaFmpZUfDPf4s8OA26l9aNVJH7XXwN5MDg0pKzuA2aFLwB3jx7oExQN4JEM/CxlBC2EiPKZbwxO0mxNsIlwHD4MndXNjpSUBaRJ/bczUczYmILq0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB6057.eurprd04.prod.outlook.com (2603:10a6:10:cd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.21; Tue, 9 Aug 2022 15:05:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::fcd7:eaf7:5345:210f]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::fcd7:eaf7:5345:210f%6]) with mapi id 15.20.5504.019; Tue, 9 Aug 2022 15:05:16 +0000 Message-ID: Date: Tue, 9 Aug 2022 17:05:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] gas/Dwarf: properly skip zero-size functions Content-Language: en-US To: Nick Clifton References: Cc: Binutils From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a38e558c-b718-424c-14b5-08da7a18919f X-MS-TrafficTypeDiagnostic: DBBPR04MB6057:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O0FVA/YB0WqfOvPzc5EGX0ezIfzEmInDxau0pyPp0jrTWUk/l6mg8CK+xrF1jbXpnIXcpV4tnxJElrmSJmCcQsSzTecO9yP6Vb3ukMrIZaiJHvrH8wC9QOYSIkfWnUqH+M2Y8EarTB2RXeYBQLZF/gvW0pCP3LJY7tJGxFO0FyZTNgos+tSBM6oKD5DdkLhwtuQAP6cgvVEi51yKqPpWc4qPh5JKyKFVDMqeRMkgzfqTC9Z3fE8+fdnHq36+fqzFdt0UhUkZeF+zHxia5nNiq31EwZB8YwrzXRu3lW2wA4lWm5WtD54GTbjVbTVWKrTkMse4LLcaNxMQp4ORmdGszxtihIx+cil9NqsGcBvRuoogDlAwoPM6N7FONOO6+n46UsaoOfHrv4njMY7GxM8HyvSyjMknul9N5DiDxmIYouWZQH0dOgZvtOETKDFxeJYNHJihzt6SzSZ5Id3Uo6cFEGQoVUQ0yHnm697/xC9As1xOiJ0mEdhy1yPvMrqFSR9gTNTOBTgs90fPu+CQRLSKhrCGLo0Y/rB8/yiRGdLJB0zQ0aHs8R1HeLozXJ3hxvfxoeNPaKgnZJ+KXA0CH292Gc7au5VYXN4NSUVuu5IARedL2iaohModf/7IOOmPHcJUYrnsb/MUOVmLPJpIC2OiyANID0YdGTv7i1J9z/d1cuGvRd1FUYHmWEqPJb1qgkrRUc6tKWB2YkI8qKBxcSyf0SgNC1IYn3hpKmq54SOtAH3ofDQ8VZf+rx5nRtReK9+MqtWLDESoED3WRTjRtW74AqfRKK48ZrKO7g+iTQsP464H9qU+XdobAjVwXWdXoYK1WaasZVa8Ic5GCfiRcTVGIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(396003)(376002)(136003)(39860400002)(366004)(6506007)(53546011)(26005)(186003)(2616005)(6512007)(38100700002)(8936002)(8676002)(4744005)(4326008)(5660300002)(66476007)(66556008)(66946007)(36756003)(2906002)(41300700001)(478600001)(6486002)(316002)(31686004)(31696002)(6916009)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjVtSEhSd1c5UFlNcW93b1Nmb3UrZmhldXFVeUYra2FMMWRCeURERVpCb1BZ?= =?utf-8?B?YWhPejdtd0Vobk45NW10WVc0MnN4RWVBblhUK1VvVFhQN0twdGp1MWpvbVBB?= =?utf-8?B?TnB3eTVOZHlTNnduVWVvTWtuSmxleEZ3WmxpTHZhaHVKTE1aL3pTSXJLQWk5?= =?utf-8?B?dXNhdytnUy9xTVRsUVpBK2k1dzE4bGd6aFVNcEdMc1AxTnE2ZGpnZ2NYbkNV?= =?utf-8?B?aWlyYVgreTJ0YitwWlhIMWU4SzdnTWpWWkp2RE8zd1FrMmk2MU5lSlFPZmxZ?= =?utf-8?B?U05uaStPWWpjMVFRd1pudEtJN00xay9UaE51MWkzYnkvbDJrdC9OQkcxK21V?= =?utf-8?B?TG1Lc01WaEVoQzJJZUJmamMvNldNM3Zqd05HbFBjVVVUdnNCREpHMzBpSkpS?= =?utf-8?B?YWt3QmFjd09MR0VaTm5YTk9CQmRsUlE0MVp1ZkFuR1pvUTJORG9lTW45aVZj?= =?utf-8?B?ejdqc0JHODl3TnFCR0o3by9xNk9JczVsQzN4anpIaTVYTi9FbU4xOTdVYTJk?= =?utf-8?B?M0VEQ2s1eEFybEVYSE05UU0ycnpJSXZiRmtlTEcyQVJvSmdsazRQakJrUDBv?= =?utf-8?B?VE5MTVpCMHFjeXVEdTZlRzF2V0E2N0d5eDFVUTNxTVNzMXg2Y21UcVh1QTJ1?= =?utf-8?B?TzQvQ3JEQ3l0KzdHVmlVY2Y0T3podU8xbjlia2ZHVDBQQnNTVmp2a2duelJr?= =?utf-8?B?dW9MdnNjOEU4RTRrRDBrYnZSV2ZxL3dEMzVhMk55c1lwZms1UktJNUx6Wk9a?= =?utf-8?B?Nkw0aFZHRE9Fb2pWaWJ2N1FkUWhSNjdkVVRFaCtGeVF4ZC9US3VQZ2FDaFRs?= =?utf-8?B?ODRZa3dtM3ZEM2plbHdDVC9POURNVHpKbk1mV2g2akNVMkE3UkQxd1hNUkJs?= =?utf-8?B?RFJENnZrN1FVOGU5RXNIdkpIM3FMVXR3WEtnYmxBK3BvZVFSVUxNdjA1SlYy?= =?utf-8?B?UkgxcldINGJ4eXBpZTB2TkxtTGkyK2VzdUlMM0E5bEhOdCtjZ3pkamtrTDNC?= =?utf-8?B?VFNHMFVpSE1Ubzk1WEdaY3RTOTNudCs4RDgwalJtMXQ2dWIzbHFFQ1l5alUw?= =?utf-8?B?M0d5OFZDbExVa0NFTHJBRFR5U0phcGlnWmlwbEYwQWgrcjhFNDFRNk82WGdG?= =?utf-8?B?YVdybUZjQkNrMDRLeHBKcjlySGlZeVZGUW5qeno5Rk1zSW5xWkk1QVZYS3hV?= =?utf-8?B?ZENSUHNQRzgvWXUwMlpiVFZNN2oyM1FVbXE4NklkdHdHdSs5dnp5ZjNxVjZi?= =?utf-8?B?WCtwb2tvdm9YOHRVUm56bG1VaytlTW5KaXdyRFlRM3RDUmQ3TzBCOXFxUHlv?= =?utf-8?B?Q0pHQW10ZHY4dzRCNjJyRTV2MDBEakFhTW1uSStuOUs3SmJ1d0x1N2dWL04y?= =?utf-8?B?UW5xNnF4RGxsQlNoOXBncDZQUTFadEFyS1BQQnFsbjZ0S2IyOVV2dC9qbTBz?= =?utf-8?B?aGx5UzBlM3Ardjk3dXFVWEJXTHZBTldqVDdieXRzeXc4dGdnelhsb3UxL1Yy?= =?utf-8?B?dTZqQ0F3RHJkczZSR3h3TDd0YWlTeERVSlNsZEFnU0grWjd6aGVWYlJjMWNn?= =?utf-8?B?OTIxSHF6dmhVRTVZMEtveTJvamt2MFdmQ3FPUWd4WjZ0NFlrMTFPcTlnZ09Z?= =?utf-8?B?OVRDWWFkV2RUdzJ2Y25JOHRLTjdZb0REZTV6VXc3UUprUCtheEJocVd5US9C?= =?utf-8?B?VVJJVW1NSVVjMkc3MWNyUGFLcUw4WmZMUWYwc1dFVDN2akIxek5CNHBHa2ZR?= =?utf-8?B?emphRVpxcGk3MjVkdVBsOUZXR1dsZkRlaURncUdMUFVLMnVwa3JhRFVkT2xT?= =?utf-8?B?dTJtNXJOVjg1cmZTUTExS1JtNEJpRWJ5eUFmZ2twOVlyN2tmUDF0U2JrcGl5?= =?utf-8?B?MHREN1dZa00wWi9BcmplUER3ZFNER0Uza2pMbU03NmJUUG1iWjdBa2xSVHZx?= =?utf-8?B?ck80a0ZnaFpHVUMrYkZFRWp1dUdieGFBaFdSbk51eTE5aXJLdWJrc1lqVWRT?= =?utf-8?B?TGpsVDl3bFl4aDZWNkR3Nmtpcm1iTWhVUldNNWJwVG5YMzZERC9MMUlhU24v?= =?utf-8?B?QWp0Z29memV2aUZoM2UrUGdrVTNpNVFSUHN0aUlOVWF2NlRXb1FKTGQzaEJp?= =?utf-8?Q?Oampka/+t09ZXzJU9svHJoGAn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a38e558c-b718-424c-14b5-08da7a18919f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 15:05:16.8522 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N/y8PzJjqInWQdUn+D7IMsMuwAKi70fEAC2wQcD3hjonOY45NMZq/mA+VNRPUkTj2q7ncSLu0L50iRAE99AJ9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6057 X-Spam-Status: No, score=-3030.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 15:05:22 -0000 On 09.08.2022 16:51, Nick Clifton wrote: >> + expressionS size = { .X_op = O_constant }; > > Does this expression guarantee that the other fields in size are > initialised to zero ? Designated initializers set all unmentioned fields to zero just like initializers of static variables would do: "... all subobjects that are not initialized explicitly shall be initialized implicitly the same as objects that have static storage duration" (quoted from C99). > If not, then: > >> +#endif >> + if (size.X_op == O_constant && size.X_add_number == 0) >> + continue; > > size.X_add_number could be uninitialized here. > > Apart from fixing that, (if I am right about designated initializers), the > rest of the patch looks fine to me. Thanks. I simply didn't want to commit it right away, but give people already involved in the bug to potentially actually try it out first. But I'm not going to wait too long with actually committing it (and also putting it on the branch). Jan