From: Tom de Vries <tdevries@suse.de>
To: Peter Bergner <bergner@linux.ibm.com>,
Binutils <binutils@sourceware.org>
Cc: Carl Love <cel@us.ibm.com>
Subject: Re: [COMMITTED] PowerPC: Add support for RFC02653 - Dense Math Facility
Date: Wed, 2 Nov 2022 19:41:51 +0100 [thread overview]
Message-ID: <aebc497a-0359-f160-035e-1d685c8fd52c@suse.de> (raw)
In-Reply-To: <35cc8fb3-9673-f9b2-e747-50e99909d530@linux.ibm.com>
On 11/2/22 19:32, Peter Bergner wrote:
> On 11/2/22 1:27 PM, Tom de Vries wrote:
>>> +{"pmdmxvbf16ger2",PMMIRR|XX3(59,51), P_GER2_MASK, POWER10, 0, {ACC, XA6a, XB6a, XMSK, YMSK, PMSK2}},
>>> {"pmxvbf16ger2", PMMIRR|XX3(59,51), P_GER2_MASK, POWER10, 0, {ACC, XA6a, XB6a, XMSK, YMSK, PMSK2}},
>>
>> Hi,
>>
>> I noticed a regression in a gdb test-case:
>> ...
>> FAIL: gdb.arch/powerpc-power10.exp: found: pmxvbf16ger2 a4,vs0,vs1,0,0,0
>> ...
>> and I suspect it's because of this commit.
>>
>>
>> The disassembly shows:
>> ...
>> 0x000000000000063c <+1596>: pmdmxvbf16ger2 a4,vs0,vs1,0,0,0^M
>> ...
>> while the test expects pmxvbf16ger2.
>
> Yes, Carl notified me of the fallout. I gave him a patch that updates
> the expected output to look for the new name. Carl has agreed to
> shepherd the patch to fix the fallout.
Could someone explain why that is the right solution?
I don't see any dm<n> registers in the instruction "pmxvbf16ger2
a4,vs0,vs1,0,0,0".
Why then should the pmdmxvbf16ger2 name be used?
Thanks,
- Tom
next prev parent reply other threads:[~2022-11-02 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 18:27 Tom de Vries
2022-11-02 18:32 ` Peter Bergner
2022-11-02 18:41 ` Tom de Vries [this message]
2022-11-02 19:25 ` Peter Bergner
2022-11-03 6:33 ` Tom de Vries
-- strict thread matches above, loose matches on Subject: below --
2022-10-28 0:35 Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aebc497a-0359-f160-035e-1d685c8fd52c@suse.de \
--to=tdevries@suse.de \
--cc=bergner@linux.ibm.com \
--cc=binutils@sourceware.org \
--cc=cel@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).