From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id A19843858D1E for ; Thu, 28 Mar 2024 16:35:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A19843858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A19843858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711643725; cv=none; b=EYLtVuqEyYP+Dovy+2F6EfzTsVuyyzMl3ebNddVFDw2O5iGpbiCyWJ5KwqjSpcBBFYMVTURGexWGmbdBz/ASs/gY8/UHWvSvQXa9jEc7+DFK835TQS2nnKufBNaxuUXD+e6D0yHiW3EErI1reqxbXVsYrew1CEdDeIjcNHJpUm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711643725; c=relaxed/simple; bh=qZLh5mS4U/D5pyNfk+pp3lKUViJVOMs8bIjBKewk3dY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FtdUtQtk9W463pkSSZNwDrw8Hw41JUcra+gF7fDEZfF17ycwAXwtyB4CP8KjWieUbzkUV3jOqg1MAWzeB+inq834MAm0DowELwHrqr/4woVoeTI8RFyDANU096qCKRWsrZXrkQXWbWerWPpWzvXSf507mabj+HIYehk/zFRR4dw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a474c4faf5eso136542466b.2 for ; Thu, 28 Mar 2024 09:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711643721; x=1712248521; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W4d4mPzwzDMZayZDrLdC3znhyR9RHov+w5vioEi8RYg=; b=flGnPhnnh2B1UlUk09n8tfxX2qBwezUoVD6SI0gnvHccUx/eB6OoBsz172YSepJLFw x1MN9szvU63mtQjjRlMhh1R6aDsw76aUAe9F7lxk3Dn0QfQ+90Qn4dAtHc0oSw+sc/T0 pQQlTx7XUFqVbSHaz5aRnBTCP2JFknbnMaTmBm9+/UnbvO9965FpkpuDjdctuXajbXd4 9EGUWx5atHMKLmyyoDo4vi5vVCodapKl2tyRu5f4X4RFmK6YvZCI8+7JI8C44T/k6ZPh 3ZtXtc9mGjWWf8g99Cgfclpvod9IY3cwEoUN0r6CvblKVQB3oYfkrVel8TLwaj4RzQeM OEjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711643721; x=1712248521; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W4d4mPzwzDMZayZDrLdC3znhyR9RHov+w5vioEi8RYg=; b=cUSD3v0RmbmBxEvKHzV1gs1AW3Cyc3Qx0izWhOz04rgVPwtO306ydPoOtTe2BJlWU0 quKOLvjbbenrgQWA5+XbubXN4uIe0geQ8Bg4XW/UBFW00dLmNPkr+N+Ko5lCT2o+6ivM 2XJ57B6SBYe4XiV7cDxlg3s7Jpjlq3CboBmmOS9gwKF329UEW5rq4pnLRqKI2vZ9J1mv nQWcbeyjNkDGWNo/qVglrezCccH79DGmx7chYkJbBgDVCUfFNFy2bJSeZwwCJE/Cb+a5 65hbbeWQuKZZ7L+8/e75D3e2ouo7SfusfgNJsrlu/3TtJeVwQdZdtCOZzkAFSAtG1B8n RAaQ== X-Gm-Message-State: AOJu0Yyc2dfF/aZgTNEvze3+axcqiFuYLsTrbZz52sSHzCF+TgdJj48/ GLtH2TR7hRtN+4TM+mwyH9pdbeGjusiwMPoHUIGq2mXMNnTIZjY/5OVqyGDxkQ== X-Google-Smtp-Source: AGHT+IEzd/+g1iurWdrt/QxciC5x42nkuRraWKA6I8EZBkhKr0qdYNTbqSJsGeiCKAR+a47Ef5c8CQ== X-Received: by 2002:a17:906:c14b:b0:a4e:70f:dd11 with SMTP id dp11-20020a170906c14b00b00a4e070fdd11mr2376783ejc.25.1711643721210; Thu, 28 Mar 2024 09:35:21 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a22-20020a1709062b1600b00a45be04f00fsm947715ejg.171.2024.03.28.09.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 09:35:20 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 17:35:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V2] gas: gcfg: fix handling of non-local direct jmps in gcfg Content-Language: en-US To: Indu Bhagat Cc: binutils@sourceware.org References: <20240328075909.4134867-1-indu.bhagat@oracle.com> <4d4ea89d-09b4-487d-8507-4a7ed3a6fdf4@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.03.2024 17:26, Indu Bhagat wrote: > On 3/28/24 03:10, Jan Beulich wrote: >> On 28.03.2024 08:59, Indu Bhagat wrote: >>> [Changes in V2] >>> - Add function level comments for ginsn_direct_local_jump_p. >>> - Add a jmp to locally defined label in the testcase to make it more >>> complete. Also, add a jmp to label defined in another function. >>> The testcase now generates an additional warning (as expected): >>> "Warning: GINSN: found unreachable code in func 'bar'" >> >> For this - can't you simply omit the unreachable pair of insns? > > We do omit those instructions from GCFG and SCFI. GAS does, however, > warn for now. Do you mean skip this warning too? No, I'm talking of only this one new testcase. Jan