From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id C10ED385841A for ; Fri, 16 Feb 2024 07:26:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C10ED385841A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C10ED385841A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708068373; cv=none; b=AsNc7a9EV56H/QFwW9TLsauLQUK0EtNNDZldMev4IdO52McwN7wrupxJa2eTUNWmcxOAUhmHGTJ6Jp+7LV6SLVafpebYoCdcuHBd+2CwFbNxyDVgGnh+FtFSrCx6Yy480XQ+UDBI6g49llRdCvBmzBjd+1utzM6gDUoFOjYRvNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708068373; c=relaxed/simple; bh=J2UUZ3pBmyGENb/JPr4rW25AFS9sTnVxSaZ0jw4Gmyw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aDRHgh9J83W+FbozI9kPFK1Bcsr1fgclBrNLKIac3Ui8l7b3i4ifl0/zmNKeCwieJaKDJJagB33DHfXZYuOwaiP+oWnHc4pVxHhA//ZsKab/FF6q4nY9DsoOj3nD9RYYtV6fSsgqC5vY+RH0U0mOvGo2iOJrR/GYgdOJTvh3iyA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-411f895c8b6so14205305e9.1 for ; Thu, 15 Feb 2024 23:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708068369; x=1708673169; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/cCdUevnflHSCN29vaGo6kxV8+kWefOQ1tVueNIehts=; b=B85ADMO9qqYl01yoIKUM7mVEEXg8uqDIE4W7Jt4sWtvbbbREP2C0MXJbKP9yMU+R6i ZpWpduo6mWoqFMzqA3Vq5INhsdCGw8pCiwjPkXt8YnH+5kZhrlrR5xBSF5dkkEIzi0OG buicwsEvZ+/dKsXPbMDzCffEdndQ9UgsfIO4n/RaRRYBgyxDjD6fJ2wgehwhidYUh7i3 tA4LDCQB/WT9khwrEj3arC+/dGmupIwoTImStuV/yW510wOSclLk63Gx9Eh5F8bhoItj hCOMo2X2e+DH+LwYtVLUJ3V/zvoBLyZYzT1FjHlAx2RypCmVVPGjLJaaeGr0ggcsxcIC 1hRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708068369; x=1708673169; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/cCdUevnflHSCN29vaGo6kxV8+kWefOQ1tVueNIehts=; b=k+KIeAfYS6RjvVin94Noms7zMRIRhEX1t7+Ti6ELnWwyz9DraSWJx8SqVTLDs/OuXB 1pR7uyJgXmdaElBEvDEnehC8xCa4XuDtrVRPqak3LUET+Nn87Efeeus/KHNVS4iWRr31 0YFOyPXe7mtS/LZ96Gd3jY+NDn4J2RYk4+k6jOuqpcae1yLZIFQV92rAQqIEauV1FizC X1gC1NzSr0hXdc7YmtSOQdYaqhYaJGFgaD89PZyUuc1AiT/25ppoZHDmOYVVaYARWM8H 4KGwONni1Mrds0wr5Xs1T+3jcDpm+c0StPRkAowfIKQNOxwZoSl1MfarcRAPWWcm51oK TO2A== X-Forwarded-Encrypted: i=1; AJvYcCXsABRY2ow///W8hF77J3y5PPYE6SbtYBOmKKdFtEW1DJ0TK70Nbf08HMkR7k9JhVKgukW5kuc1YHRF97GyxGfP0u94/6qKhw== X-Gm-Message-State: AOJu0Yxk5jzvCHuas5dsoarRbMj0O/KLSioNK3hCDprO2ZdbvGrJ4dqm qotjAfd2xva2vz/ipTWMQC43my+xQ9S7iOHl8k5s5ySYFI1A9hAWY0kLd60Q1g== X-Google-Smtp-Source: AGHT+IGuPhykaLtp8ZVQug7oeJtDEYklSXZvOUphcQdqbrp8Rmiyh0Kbz5u+uxcXP4UiTO9/ZWOf4A== X-Received: by 2002:a05:600c:4710:b0:412:40fc:46aa with SMTP id v16-20020a05600c471000b0041240fc46aamr662482wmo.41.1708068369467; Thu, 15 Feb 2024 23:26:09 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id m41-20020a05600c3b2900b0040fc26183e8sm1453618wms.8.2024.02.15.23.26.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 23:26:09 -0800 (PST) Message-ID: Date: Fri, 16 Feb 2024 08:26:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: adjust which Dwarf2 register numbers to use Content-Language: en-US To: Indu Bhagat Cc: "H.J. Lu" , Binutils References: <262f296e-673b-47f0-a764-276939161d64@suse.com> <15c6acc7-21f8-44bb-bf0d-97392f2fcd37@oracle.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <15c6acc7-21f8-44bb-bf0d-97392f2fcd37@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.02.2024 23:22, Indu Bhagat wrote: > On 2/9/24 00:11, Jan Beulich wrote: >> Consumers can't know which execution mode is in effect for a certain >> piece of code; they can only go from object file properties. Hence which >> register numbers to encode ought to depend solely on object file type. >> >> --- a/gas/config/tc-i386.c >> +++ b/gas/config/tc-i386.c >> @@ -5409,7 +5409,7 @@ ginsn_dw2_regnum (const reg_entry *ireg) >> if (ireg->reg_num == RegIP || ireg->reg_num == RegIZ) >> return GINSN_DW2_REGNUM_RSI_DUMMY; >> >> - dwarf_reg = ireg->dw2_regnum[flag_code >> 1]; >> + dwarf_reg = ireg->dw2_regnum[object_64bit]; >> >> if (dwarf_reg == Dw2Inval) >> { >> @@ -17461,7 +17461,7 @@ tc_x86_parse_to_dw2regnum (expressionS * >> if ((addressT) exp->X_add_number < i386_regtab_size) >> { >> exp->X_add_number = i386_regtab[exp->X_add_number] >> - .dw2_regnum[flag_code >> 1]; >> + .dw2_regnum[object_64bit]; >> if (exp->X_add_number != Dw2Inval) >> exp->X_op = O_constant; >> } > > On one hand, I see that the suggested code changes are making things > semantically clearer, I would like to understand: > > 1. If there is a scenario where flag_code is CODE16_BIT / CODE32_BIT and > object_64bit equal to 1 is supported. gcc passes --32 when using -m16 > or -m32. Well, gcc may never produce such input, but hand-written assembly can. > 2. Irrespective of #1, shouldn't we then also use "if (object_64bit == > 1)" instead of "if (flag_code == CODE_64BIT)" in md_begin where we set > the value of x86_dwarf2_return_column etc ? Good point, let me make a v2. Jan