From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2046.outbound.protection.outlook.com [40.107.22.46]) by sourceware.org (Postfix) with ESMTPS id 082A03854810 for ; Fri, 30 Sep 2022 05:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 082A03854810 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S5k9LTO1UFziC8mm0traAy4LIhrlWQwsai7UoAkr/UO0dOeRRWHjuYtlgwZFkbwmvjbzW64DwDKSMyRgXzpXaxSrkSeZkwT+beWVoQWawF8bBBndamPitETmoSBr5WnZ5cNjfKzUf//OZTX5KIUQMZR4Jmxup7e7BMNoo/5wn3+6oGjvazYA4bBb5o19HPFJwmICOYu3L8i6JUX8t4khnQUWxtkGmmSt86vHecapB9eZsuTI+P3io9l4gP1SIQ8fNZIDH6UEkI7iZwQD8DrYnD8VBCOIO6/5Oh7Gptg4qsf8HqQoDVy/O7tqgtr248vHgjhJbguKN8sj7woez8ml4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MauBAvnWFdblsBkUkmzjC+0O77u5+ZMIqqxZTxDoCso=; b=Dh8QiSGgIR5kAT1WyvGc7EK+XOx+Ylr9CSGHjU1UQdBKkZryE4r8tbWye6OpFxNAkr+3EMiaqWFRQr34Fd4dNiAZQ5+ERvL/ghJCyBrfmhIVN2tUajRPGd0zRn41PO/9VjV5gacQaXo+mdRzgTYjbhfwoESlGAnIMybawCAKkQymG70CB+cSOZ8jQmDiYGAKBOrT5LprM84AzHkoUycr7jvyxd0BPXcoBB0Z1BsQ4wQ7SqBcvUBx1VD9t4rxhTkg0cgziTNE4dlvJkN5NrQu4vdyPtENHmfMr/Ito92a0WTeV/ma95QVdRJR+iHLZn0pMHKYU08+l22potBP/yKN2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MauBAvnWFdblsBkUkmzjC+0O77u5+ZMIqqxZTxDoCso=; b=znlmcVEqJOSXbrd2ejr4o+38voaCJqz9ILBGUUyswcssFEACvWah38oCt5LNRNREPOA7quKXpp/atJfC8HqmUgKaevrPRWnkSGQMQDB1F/I7rzy6A6jKyoNrXTzLIt9Sg8M4zp0SglMPE4sAYXo/21FuYy1ROYaTTjt0fXih8lYObaq7JBLOv6D3DQuplDVfttjkrqctPVLXY3FXt9L/t9sWoDGxwofxvX8ZCoVpBNyFPDOucWCe8QUWVONtlsjRcNtQYyw6/4A2wAAviMJDFOVDOs4ibglsMvtFszTfFxwBsAIPiYYRte3196YyecvDomuWmaz/7V+7zC1Aqf+syg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB8018.eurprd04.prod.outlook.com (2603:10a6:20b:236::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 05:53:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 05:53:24 +0000 Message-ID: Date: Fri, 30 Sep 2022 07:53:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5. Content-Language: en-US To: "Potharla, Rupesh" Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Kumar N, Bhuvanendra" , "Potharla, Rupesh via Binutils" References: <8f9d1b9f-01d9-c415-d362-57fbade05b81@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0004.eurprd03.prod.outlook.com (2603:10a6:20b:468::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB8018:EE_ X-MS-Office365-Filtering-Correlation-Id: 319256a8-41a0-49b2-95ab-08daa2a816a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f5ZsfZwhXUfDixBJFJU6ce34E8eNCXpigIjlAqEqdm8d7vkX0ihry1ZigQjOU7KBiKpG+qVRO8LoS3QFnQ/vZfbfGGL0NmTpgSEsrvmSs6GsQbdHqR2Xhh7GN8WUhKezQZ4Q4jcEnhzqS0B8BPor9KFNWb6kVFqx7MZeCZc0Gv0YSalaBp/bVqeT5h7MHOj/ECizlMIduckwJSAqskZDryBXyljHB8ug5eGBo4OX1YYxXHRfFsIR4R83OCx3NP+mHY8x0z9//HbD1opsP4CIbVooTWOxk6gf0P776kw5V/DHkZbgbs9BBMh7mZwmWUDCLzlZauxPQ5HoI2xR6SrpgiV9czMSjRAmYBOBddN9Fg6x7xAPWcAqasRw762Hsh7WBzf0mZpVTPs/kp68jJBCe0PrPyVYpp6uUCILLsuDVtWtYHapnvwtlQrIpUd21vVWCxC9f7s5ODphtkxrbDIiLLZ+AIK+S7S+Og0chIdN8eUZlZGR5kEqF+1CPdqvIhhcH20eQcfp0qoVbCvXEoAmKJs+8pA91Tihna98WeId10Uig159Zs0UYoMQt6esD8Ikl1uoK5q/gA3ck9hD+sv0iO2HuE/pCnO6kR56xagGBwxJSuaEBFdik2d9G0fAfuSTju6pw4ur821ATyBqNo+alIeYPPUUDujEqTOHNP96v3OqsZJyLvpInOz0qOOhRM/MIhzq/7i3BnARxWp0eYrzRrPHpAFJ8LbijnMQPt7Z823h8LIQ6l7g8WGv3T2zdsOA0/rIYZ5Df8V2t0QdwESTuWvsFg99oXDM/XByCrXjDMg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(2906002)(66476007)(6916009)(66946007)(86362001)(31696002)(4326008)(8936002)(6486002)(478600001)(38100700002)(41300700001)(36756003)(31686004)(186003)(5660300002)(8676002)(6512007)(26005)(53546011)(316002)(6506007)(2616005)(83380400001)(66556008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUV2SW03OUZ0Rkw0RVZNeVZHNnZVajVvWTRDemhwT2J0YWhsbXArSE9Wd3pw?= =?utf-8?B?d1lNTkZYcmhNZVExbytLdHZ5eThQcG1FdDRGSGdHYVpkSDNpdDhjOXpxM1p0?= =?utf-8?B?SEQ4eVZVL01Tc1JvOXo5Qm00MzQydG5mZXROME84b2NJKzFvWDZHYTZVMndr?= =?utf-8?B?M20ycEN4eWo3SVVwWFF0ZlV6UVdBNGo1VGxRcTFtUGVPSW94dzVlR1dyZG92?= =?utf-8?B?KzVFU29PRVd2NnVYUm5Gb1RpaEZSRW5QUDZwWVdVK2lWNzF3SmprYm40UXF6?= =?utf-8?B?bjNXZkpTZm9BSFVlOUhXVjJNMkFYU01IekIvQk12WmtjVlVoMDl1MGhYRVNV?= =?utf-8?B?aGZvcUFuMG1rdkttekM0M1ZuQzNaOFNtMGY0QWpBZDlHcldBdkd6S3hEQnhK?= =?utf-8?B?WGdBUC9QcXdlZ2FEQUtzWEdvbDNOUmg2Z0lPYUlIcVVwT0ZjaHFveGJBYVdT?= =?utf-8?B?NWlURlVFSjMwMW1wNTJzYkVzMzcrNnVYRVV1b053b1NXUUU4TTc3SXoxL0VI?= =?utf-8?B?ck1QMWhJbWMxRjdWeW4xd2JMOWppRS9yVkJGT3JzOExsVnl5c3ovOFFvZE1j?= =?utf-8?B?VWFiM1BwMUc1VVQxUWNoemtOYUVtWEtaV0VGcGQ2ZTg2dVNwSlFvTkhnTUdM?= =?utf-8?B?WStMTWJ3SEM1S2JKTXJaQldNaWlOUCs2NWlMV3AxY3ErT0V6UkJhbVJYSXJq?= =?utf-8?B?SzJoY0pJQ0VrWlJiZEg1bXMya1RES1pnMFJERWhBYTdCYUlGeTNRRWd5bjEz?= =?utf-8?B?QmFXS2pLZFNFR2pYaWlnTVk0a2JFOUd0amFHK0IvQzNvTkVTZXFBai9RRysv?= =?utf-8?B?YTk3TzlnaDBkTTlWUjBvZEp3RVhNZXBtWXpVSmFURVhOcXVQZXpXd08rSnRk?= =?utf-8?B?QUQvVXhZWHcxUkNKQVAvMm1MOTliK2VGZHJDNytVYTF1dkRsOTlGeW1YZjRN?= =?utf-8?B?Ukx6U3VqYlpyOEtWQUxoekRGMko4Szk3dHB6OVpQbDdQVlVBUmdvakJUeGoz?= =?utf-8?B?T3hwRDNxdUU3Z3BwS2x6ZzNwRG9xVlJDbnNYREgxMy8xZm4vekU5UGpOYzBp?= =?utf-8?B?SEJ1TjlsbEQwdDNnVW53aGg2Mzl6cjd0VjdENk53ZFVaS3BGckgrUVhnZnZq?= =?utf-8?B?T2FwQUxqTkFoK25aREE2alRoM09BMVJPOTdKWVhqTWdmMi93bnRxdERGMVdX?= =?utf-8?B?UnhmWUNNbDkvdllqYkN1QmpKbmo1K3JrYTN3ZGhyTCtoOVRZVmt6ckV6cGM1?= =?utf-8?B?RnV5NTkrWEswOW1VYlhSdDNsUjhTdmd0RFZnUmhMYmNjYldXZVI1aW16blFC?= =?utf-8?B?emFYQnZUWVZ2SEFZZE9uY2lqdW9icnFLTDY4UEJwVmpkcUJZazhKMExxdzRQ?= =?utf-8?B?VGJhbTlXSmEvaFB2TzR4TlVGZ0FZL0Y2VkluL2RtSzkzN216enpBL0FRSUtK?= =?utf-8?B?Q21xY2dFeWdaS1NhYmplWGVXNVA5eVVvUXovZ2FKWnl4dDByOEE2a0VDQk1E?= =?utf-8?B?RUE4Z0c0UFBCMWlKbm5iaDg5aXo5a1R1WWI0c2p5T3RTRFBTbFhoVUd5em5U?= =?utf-8?B?cnlTNUtIYk9MUUFNT3FJWm5hZHFwMHY3U3BxdFBXelo1NytFQllDOERlM2M1?= =?utf-8?B?STVNRGpxdGtSUG1qc3M5cWlzdW0zSVRrTnBNSlNwS29jOTBleEpjam9ROVh4?= =?utf-8?B?c1NsNUJ5Z3UySjU1UCtCNnpwbTVPenU3L2lrVVlnUVhyUVZDUmdyc1V2VzBG?= =?utf-8?B?ZE5LeGVCTjlINmxXK3RaY2lzZVRVMWE4TkVrZGxVTUpka0pra0tERW5FNkwz?= =?utf-8?B?Y3MrLzlYSGtESktDK2dqdUR5ZDBqNEtWQk8xeW94TkNHdnRVbng4OFc0YU5h?= =?utf-8?B?T3AzcVdneGpVTVdaZUZhNWJ5UktMRk1MbU5Wbk9WSGxsQ1Y4aTR0bmQ2MEhG?= =?utf-8?B?WnZpakh5WTg5SStrN1hacmZSYUU0aXBDeFFKRWJIOHRzcURweFprb3ViNjJI?= =?utf-8?B?UlQ1dk1OK2VYV2RQTEZCVm8yVkg5eTdBak5mVXhDRE5jYnZaN2xXdVBaWFow?= =?utf-8?B?cHY4Ylh6VFJDSzl5Z0plQTNlRVhCWDFPZ2ovUW5KQ25nZDBJRENhL29CSEJv?= =?utf-8?Q?52FhFp2G1yo4SPD6xKnKu6pN4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 319256a8-41a0-49b2-95ab-08daa2a816a9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 05:53:24.6951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 66YFsGk9nmIyImN52mgtnyzO+mlZmyv+oO7JO6NWDxvD0aBdHgfhiOrZUmlDxdDzqH7itOJwO/2N9JpbD/RYcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8018 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.09.2022 18:39, Potharla, Rupesh wrote: > I made the suggested changes. Can you review the latest code changes and send in your comments ? As a general request - please send new versions as independent new mails, with the version number bumped in the subject (e.g. here: [PATCH v2]). This makes it easier to follow revisions, especially when later looking at the list archives. > --- a/bfd/dwarf2.c > +++ b/bfd/dwarf2.c > @@ -4411,13 +4411,23 @@ parse_comp_unit (struct dwarf2_debug *stash, > if (version < 5) > addr_size = read_1_byte (abfd, &info_ptr, end_ptr); > > - if (unit_type == DW_UT_type) > + switch (unit_type) > { > - /* Skip type signature. */ > - info_ptr += 8; > + case DW_UT_type: > + /* Skip type signature. */ > + info_ptr += 8; Please follow existing style, indenting the case labels the same as the opening and closing braces. You'll note that this way the diff will be smaller as well (which, besides patch size, also improves the results of e.g. "git blame"). > - /* Skip type offset. */ > - info_ptr += offset_size; > + /* Skip type offset. */ > + info_ptr += offset_size; > + break; > + > + case DW_UT_skeleton: > + /* Skip DWO_id field. */ > + info_ptr += 8; > + break; > + > + default: > + break; > } > > if (addr_size > sizeof (bfd_vma)) > @@ -4441,6 +4451,7 @@ parse_comp_unit (struct dwarf2_debug *stash, > return NULL; > } > > + > /* Read the abbrevs for this compilation unit into a table. */ > abbrevs = read_abbrevs (abfd, abbrev_offset, stash, file); > if (! abbrevs) Please don't introduce such a stray blank line. Jan