From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 8FD71385842B for ; Mon, 9 May 2022 20:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FD71385842B Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 249JI5lZ004658 for ; Mon, 9 May 2022 20:06:16 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fy9098sn0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 May 2022 20:06:15 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 249JrK0i019301 for ; Mon, 9 May 2022 20:01:13 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma05fra.de.ibm.com with ESMTP id 3fwgd8tarv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 May 2022 20:01:13 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 249K1AQA45154780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 May 2022 20:01:10 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9ABBCAE051; Mon, 9 May 2022 20:01:10 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73E99AE04D; Mon, 9 May 2022 20:01:10 +0000 (GMT) Received: from [9.171.4.36] (unknown [9.171.4.36]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 9 May 2022 20:01:10 +0000 (GMT) Message-ID: Date: Mon, 9 May 2022 22:01:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] IBM zSystems: Accept (. - 0x100000000) PCRel32 operands Content-Language: en-US To: Ilya Leoshkevich Cc: binutils@sourceware.org References: <20220504103648.1724970-1-iii@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20220504103648.1724970-1-iii@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: jNjylTn9aibaBZx4J6cddemthE7yLOi_ X-Proofpoint-GUID: jNjylTn9aibaBZx4J6cddemthE7yLOi_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-09_05,2022-05-09_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 mlxlogscore=859 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205090104 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2022 20:06:17 -0000 On 5/4/22 12:36, Ilya Leoshkevich wrote: > as does not accept instructions like brasl %r0,.-0x100000000, because > of two problems with the generic overflow check: > > 1. PCRel32 operands are signed, but are treated as unsigned. > > 2. The allowed range for these operands is [-(1 << 32), (1 << 32) - 1], > and not [-(1 << 31), (1 << 31) - 1]. > > Fix both by disabling the generic overflow check - it's not needed, > because s390_insert_operand () performs its own. > > gas/ChangeLog: > > * config/tc-s390.c (md_gather_operands): Set fx_no_overflow. > * testsuite/gas/s390/s390.exp: Add zarch-z900-err. > * testsuite/gas/s390/esa-z900.d: New test. > * testsuite/gas/s390/esa-z900.s: New test. > * testsuite/gas/s390/zarch-z900-err.l: New test. > * testsuite/gas/s390/zarch-z900-err.s: New test. Committed. Thanks! Andreas