From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2048.outbound.protection.outlook.com [40.107.104.48]) by sourceware.org (Postfix) with ESMTPS id 41CAB3858D28 for ; Fri, 24 Nov 2023 12:14:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41CAB3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41CAB3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.48 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700828048; cv=pass; b=taRYYeMS+VWkgi2avXV0gyEOuc0OtfkEBG4+nR2RJhnrXhyOW/E9GJ4XC4sz7p9iv/P4AjgkOdjCsayoEhhVqCYdthRjAam2kHznu2r/IWDhrK4AHO1kk1vMinhZErY++qt/dGTCoZbBKS9p463p/yetGlX08t0U+42siElKuJ4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700828048; c=relaxed/simple; bh=ZkH2jTFNyMgYY6/vwIpThlvMXZUeA/aoDmaBHJ4eu30=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=llAzUdwhYDBAZLlXtoYmHUAMxJ7kfIc43TXdYjCP8Kbu0t8hT/Y5yIaiNPON1Pvyit4ZoTFs7rUAmT6SQTcDzgo/fIvw2i4DWXvr4PCGslLBL7kkKA/7tz/OPSQjykHeO9tISPwanGBPSXpzxcWY0PrpIT6TDlUv+3yN+uhHtkM= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZagzI8Zfh0IFEy07S5ZDE0nd5YF4g5FBK0saN0Zq2Uk0iYU8lPvpLbnUgp1FbQZwtfETtUFFLrmyPKAzXQqOX+KyuLi9BZfS8CELDBgSZxRErr8jcsdnXdepRxYPVNH92L0Xb8u0G6vg6WWEoE+QmghMjGL/EbwHswZv8bGxAF0rloL6SzpzefDYSHQ6pNRtrkQBDW8Hy+YnlkAPeMWwfuzMUKe90zojjHaxvBXCr4j0XOObtYJA/Y2humuwJPMdDFK8fgvYQOlAArKS8+vmKuQrHSNKpYgOMF7sX+G3q8B5NbA++rGogwOMSuJktIX4CA9Wr8tyvOg2Mp3+16AhGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k8TqdOZZuf8ees535HaGriQqa7kPMJb6k5Nz5qTsmXU=; b=lgx+bLMGCmnY5lkhoiewm8+a5FRnXPmJVUt2KwEf/DQnfkole5pSBZ0XyomCbiW1q/9TrULOU1XAD5xliPTxEydkPXV3LM9g3R+mNC7CaNYMKM8ZeFpnLM0OuDvhGNIkUlXgMHMXF6Kgq/0F7fBxqMEce99crUhi193DXFdGKLGlZspWpP/+4FIAS3uqMghvlvhjRMq6O9yOsm+8cXcRHRsHzQDc7xwknwWwHwVDqdVrbz0dX9j96aIhYzb25vwKgRZ+1mLFZ/b9mwG2+ELq3g505TyxGHhLPowDqCSV/62BvyX55/vW74R53ZHwnPQ/3TwdIlGNGJdZjxYRtSNXrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k8TqdOZZuf8ees535HaGriQqa7kPMJb6k5Nz5qTsmXU=; b=EqcpdCCIkWWMDgLVVc91lj+AHmSqtA7DiiDUF144mleuWhFPHerRIfsdKWnqQv2lnw0s/pVYa+Qq8/IqL+q1nzoslUtdebwjiRu1griji+TXtyKpRsoXZzJL6D7RrxJTKAVy1FbgRKiksmJEZgCo2G7eNWRVX1HK8XaWqNLMNt4UybuDWTQTt22yd8eYTgXkpgRbVA5gaN7u21dWrlkU8d2izo4Oq/Qy/Bkj5OOYncp3Zd1M0BNz75v6l7QVT5YkQytTGCJiRk0CvXBmLCT1NmBjSN1ECwY6Ngd4HbrFB7yD2wbnfSMhVfZT3553zQg6YzRE6Uf+Gm4MG+od/dBAKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9521.eurprd04.prod.outlook.com (2603:10a6:10:2f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 12:14:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 12:14:04 +0000 Message-ID: Date: Fri, 24 Nov 2023 13:14:02 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] Make const_1_mode print $1 in AT&T syntax Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231124070213.3886483-1-lili.cui@intel.com> <8a3b094b-b9d3-4aed-8dda-cb01c6a053d7@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9521:EE_ X-MS-Office365-Filtering-Correlation-Id: 77988495-83bd-4c42-8e0f-08dbece6d99c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: af/Swm3dn4X0clU8uWXtHijGzQAU6ekPKgU2Y+educqem4JMx6ySSJ/XvyY8fdoxFkJEtglxCjkPJJmhLCF+E8rIUAf2Tvc0zx0nyv3IMTGedf6ELkQJPRdYwPml7n7+nOWni62yRU0nXgvGuPoerWX0HG9vq1g2U60/uOYLMe/PepLea7Yg90M7cRXMmYigcvP4eJeMtxhxejGdWBqamDAkCpcl02RcRjhTP1Z1EpO7sngJv12LeYBernihklLCXBG3K7fAAY1l3vQCC/QpH8nXQvcOb5N/xsJUtPHsK/5IhcNKAKgW/NV4ig5jnVJd8nmn1AaLtASL7Ry/IU+FKevkamMf/Om+nKQ94vpgFYAIefIgbQAPQ4ZX8WO8jyTO5ORdzwbPc6iighZblqxqgCfAkX2REPgBhdvU8VVH76NvogZDU56qQ/4nXIDzAtBx/z/DvIff+F0QMsMzpaU2gjjxbVbwDRoROLX6afga+vv15AI3vmn4y0daOCKWQMmh7QKwycV8Iy/e9Sbm426ECvFq7n46Da2rpgTwEFnqjSE0FgQB2NtcCVbD4YUX/u9hlqahp8KFb880AbB9GwsESb/gq3H+4xVwpZALVGy0fVugVqNKPxcpJVkUKo8iKw/FzlgIz9x9EObmiUcfgGseDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(346002)(396003)(136003)(39860400002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(26005)(83380400001)(53546011)(6506007)(2616005)(6512007)(6486002)(478600001)(41300700001)(5660300002)(2906002)(8676002)(4326008)(316002)(8936002)(6916009)(66476007)(66556008)(54906003)(66946007)(86362001)(31696002)(36756003)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3piU1RsaG5NTVlleGJrZDYwbFdLRytEK1BleXNzaTdkU3lmQkJ5QmJXRVE0?= =?utf-8?B?U0hpdnpwdElTYTJnamFtU05lOXk0d3Jyd053TXg0cVU5S1FxdmdxY2czVlEy?= =?utf-8?B?eVQwN0RwN2d4eWI3elRIL2dNV1haNHV2QXJiZFFXL01FL1g4am1kdW83Vmpl?= =?utf-8?B?Nk5RMjZVRWlVOWl1VEFuTUJ4UzZDVU5RVlY0UW4wZzhabGlZdlc4ekpQWENL?= =?utf-8?B?ZFlRVzA5Y1dPMy9LZmViNFlzQTBHNDF5QkJydjc0NTBLb09Demp4cDBUdWs1?= =?utf-8?B?NzR4MnpjOFFMOTBKZlRBZHR5VGZjcjJvVll3SHhNNjRLYUdoRTRFVldMUkdL?= =?utf-8?B?UDZYV01BWUZMbTE0MExDSmpYT3BaL2VQMTVUckdQQ0JDMmlEWEJYYzhlSWtC?= =?utf-8?B?WEJFeVEyZlNVSUVhS3BMbnpqRXJ0N2JFc0hQa1JWV0M0dkZtckdHclBjRXpl?= =?utf-8?B?ZWtjSmxzZmc1TDI3dEh4aWN4MGorUWVHblhpV3BncnRTRG50bFFBR0xyV0tB?= =?utf-8?B?M0F5eDMvZk84SDlxOGYwYk1hdUc1MkEwdXBtWUtqMkZ3NWROUUxlSjNZMGVI?= =?utf-8?B?a3hVZmJtbWtUQmd3MEhRZkJ6L3FGQjVqdGV4a2N1UUR2bnJFU3JkVy9NYVRQ?= =?utf-8?B?eUZ4b3ZnRFVza1NBWmlYU3dTSGVWUEd0bDRRcHA0RkVpZWtoeTFUbDEwdVpO?= =?utf-8?B?aTJ0KzhrTnEvVTZBcUFmODR3SU1tVzdmc0dSUHc0dFJrRkh5UkRScG9aR3ZG?= =?utf-8?B?TmZ0bHZXUUlvZFpEQkF5S0NoTVJHSjZkK3ZMOUR6RWZrT3pRU1J5ekIvVUR6?= =?utf-8?B?OC9sNm9VOHJ5aWkveTdLeGpUTUorSVZxSno0L0RjZWUrRm1QYVVOTnArdGdN?= =?utf-8?B?QkREaXp3TEl3RmJSOGcwZllGUmxuNzhqZDhJVVN3dkowZFFLTHVUdDl3TU1H?= =?utf-8?B?V2RzelZzY3UxM0ZJelR0TlNTRmVzZTVORlh6MnNpTmwzeS85V2pTZUZ4QXEy?= =?utf-8?B?TGhlSWdIWFp3R2xkU21lUDBrRTF2dTJ1Qk5sUUIvL1Fjbm91K0RPby8vRE5R?= =?utf-8?B?TnFjUUxyVTZXNEVoNjl5SEROblExZ1NjNVVaMFRpVXR4WDRoS2k2d1hhZC90?= =?utf-8?B?MUxGcWl0UnN2Z29LcjRwQjFlNHJkVklPbVdobVhMRXF4ajJBSVFJSFJmVERB?= =?utf-8?B?ak9uaUtTYmZNVURMTCtXdkN4QkhFS0ZRckkrUGsrRDJ5WWg4Y0Z5VzBpc2I5?= =?utf-8?B?ZDF4WmZmbFVuSElTZy8zTGl1anQvTjRML3FOT09RUUFLOEwrK1M3Z0hienoy?= =?utf-8?B?TW5mL3VsVzExZHRtd1Nmc3owTzJBUHBtTTV2NiswUldGOTBBS0dqMzBIYXJp?= =?utf-8?B?ZTZ4Wi9pYWJKS1J6cHAyekVLeDVFVm1VNE0wd0U5ckc3N1dtamhDWlBPeUJp?= =?utf-8?B?ZEZBcm5GejZpeGo3cEtXZ3Vmb0ZrZVlaeWVIRC9NeXZRenBEMDRRWWEyKzZK?= =?utf-8?B?eThGZzBjQkc3UWtwb3Z6cGRmemtlM2hDZ2lKalZTOW5VVlFON2w4ZlJkbllI?= =?utf-8?B?cnRPektpVndleHROZU9vbFhJd2t5ZHdqUm8vbkxSUEVzZlRTOWxDR3JTc3dx?= =?utf-8?B?K1JJdUp4NVE3SVBHMERQamVaUEExNm4zL055ZGxxWmw2L2tTWmFpcUM5QlFu?= =?utf-8?B?eGVqV3g2MXhqTllPaWJxTXRMRU9LZllFYko1K1V5Q1FrUWliQXdnMVBnS2Ux?= =?utf-8?B?cHRqVVBQbHNqREVTTmdqcjFHQWcrVmllaFRyZExKWjVWSzVHcXlJUjFlS2Ji?= =?utf-8?B?emtmQzBGQW9TVkNiUU1VVjNscVhWOEZPU1hnNjRQZjNkb1lnMjY0UW0vc2Qr?= =?utf-8?B?Vm85ZC84bDVudXY5SUs3dUcza2ZXUmVqZmxwb3oyd1dGYTMwVnZKSm0yd2lI?= =?utf-8?B?NWVEOC9BK0Nocm9ZN00rTGhibElZSzRBb0lwUi9uSHpUUWk4WFpQRzUzM2pk?= =?utf-8?B?M2lmMWhYazJUY0x1N3ZJc2NmNm04cUV3S1hwRlY4YnBGM2dmWEF0YlMzRzB2?= =?utf-8?B?cVBZNFJaelFoZ1l0MUdFLzAxbVNxRUtGVEh3RHZqa2RNN3JDc3BVZ0duelNw?= =?utf-8?Q?SdAC1Yl+UwH5V+bCd5Vxp/VRo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77988495-83bd-4c42-8e0f-08dbece6d99c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 12:14:04.2390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6q7UOlkCI/miuRNzVQWfajhQLfqPPfSPDIwX73jcL2FNHquFicCy6x6C+MYJMP1sLqpgSbCvt9FsmwDrKB5VfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9521 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.11.2023 12:22, Cui, Lili wrote: >> On 24.11.2023 08:02, Cui, Lili wrote: >>> Make const_1_mode print $1 in AT&T syntax, otherwise there will be >>> correctness issues when it is extended to support APX NDD, >> >> Looks fine to me, but I could easily imagine this to face H.J.'s opposition (and >> hence my suggestion in this direction wasn't exactly this way). Since iirc he's >> going to be back soon, may be best to wait until then. One request >> though: >> > >>> --- a/opcodes/i386-dis.c >>> +++ b/opcodes/i386-dis.c >>> @@ -12090,6 +12090,8 @@ OP_I (instr_info *ins, int bytemode, int >> sizeflag) >>> case const_1_mode: >>> if (ins->intel_syntax) >>> oappend (ins, "1"); >>> + else >>> + oappend (ins, "$1"); >>> return true; >> >> This was already overlooked when output styling was introduced. Please >> switch to oappend_immediate(ins, 1) here (i.e. replcaing the entire if/else). >> As per above - from my pov okay with this change. >> > > If we use oappend_immediate(ins, 1), it will print $0x1 instead of $1, and then Imm1 and Imm8 will be confused. > > regexp "^ +[a-f0-9]+: d1 f0 shl \$1,%eax$" > line " a57: d1 f0 shl $0x1,%eax" Hmm, yes. Albeit I'd like to drop pointless 0x output anyway from oappend_immediate(). But for now I reduce my request to you then to just get output correct styling-wise. Jan