From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11636 invoked by alias); 6 Dec 2010 01:38:51 -0000 Received: (qmail 11409 invoked by uid 22791); 6 Dec 2010 01:38:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Mon, 06 Dec 2010 01:38:46 +0000 Received: (qmail 74127 invoked by uid 20157); 6 Dec 2010 01:38:44 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 6 Dec 2010 01:38:44 -0000 Date: Mon, 06 Dec 2010 01:38:00 -0000 From: Hans-Peter Nilsson To: "Maciej W. Rozycki" cc: binutils@sourceware.org Subject: Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00206.txt.bz2 On Thu, 2 Dec 2010, Maciej W. Rozycki wrote: > 2010-12-02 Maciej W. Rozycki > > gas/ > * config/tc-mips.c (mips_ip)['u']: Report the value of the LUI > argument complained about; reword the message. Just a bikeshed comment from the sideline: The [] in changelog- entries is canonically for conditionally defined stuff; within #ifdef X/#if X. For case statements, the canonical marking is or , like: * config/tc-mips.c (mips_ip) : Report the value of the LUI or * config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI Feel free to ignore this, I just don't want your format to catch on - and possibly be forced to use it. ;) brgds, H-P