public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH]Add support for Open8 configuration to config.sub (from config.git)
@ 2011-04-04 15:01 Kirk Hays
  2011-04-04 16:05 ` Hans-Peter Nilsson
  0 siblings, 1 reply; 4+ messages in thread
From: Kirk Hays @ 2011-04-04 15:01 UTC (permalink / raw)
  To: binutils

2011-04-01  Kirk Hays  <khays@hayshaus.com>

	* config.sub: From config.git: Add configuration support for Open8 
	MCU softcore.

diff --git a/config.sub b/config.sub
index 18b17aa..30fdca8 100755
--- a/config.sub
+++ b/config.sub
@@ -286,6 +286,7 @@ case $basic_machine in
 	| nds32 | nds32le | nds32be \
 	| nios | nios2 \
 	| ns16k | ns32k \
+	| open8 \
 	| or32 \
 	| pdp10 | pdp11 | pj | pjl \
 	| powerpc | powerpc64 | powerpc64le | powerpcle \
@@ -394,6 +395,7 @@ case $basic_machine in
 	| nds32-* | nds32le-* | nds32be-* \
 	| nios-* | nios2-* \
 	| none-* | np1-* | ns16k-* | ns32k-* \
+	| open8-* \
 	| orion-* \
 	| pdp10-* | pdp11-* | pj-* | pjl-* | pn-* | power-* \
 	| powerpc-* | powerpc64-* | powerpc64le-* | powerpcle-* \

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]Add support for Open8 configuration to config.sub (from config.git)
  2011-04-04 15:01 [PATCH]Add support for Open8 configuration to config.sub (from config.git) Kirk Hays
@ 2011-04-04 16:05 ` Hans-Peter Nilsson
  2011-04-04 17:19   ` khays
  0 siblings, 1 reply; 4+ messages in thread
From: Hans-Peter Nilsson @ 2011-04-04 16:05 UTC (permalink / raw)
  To: Kirk Hays; +Cc: binutils

Re subject, you mean like it's committed in the upstream
config sources?

On Mon, 4 Apr 2011, Kirk Hays wrote:

> 2011-04-01  Kirk Hays  <khays@hayshaus.com>
>
> 	* config.sub: From config.git: Add configuration support for Open8
> 	MCU softcore.

If so, then this should be something like "Update from upstream
sources." as you can see for previous imports. ;)
(And it should be a full update, not just a patch for your port;
I don't know if that's what's going on.)

When the changelog instead mentions the specific change, it
looks like a manual patch which is usually due to a
misunderstanding of the process, but we've been over that.

brgds, H-P

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]Add support for Open8 configuration to config.sub (from config.git)
  2011-04-04 16:05 ` Hans-Peter Nilsson
@ 2011-04-04 17:19   ` khays
  2011-04-04 18:00     ` Hans-Peter Nilsson
  0 siblings, 1 reply; 4+ messages in thread
From: khays @ 2011-04-04 17:19 UTC (permalink / raw)
  To: Hans-Peter Nilsson; +Cc: binutils

 
Exactly - I approached Ben Elliston with a requested patch to config.sub, and it
was approved.
 
I searched the binutils archives for the instance of "an upstream commit of
config.sub by someone who lacks check-in privileges", and missed it, if it
exists.
 
Given that I don't have checkin privileges (nor should I), I made a guess that
submitting the change as a patch was the most correct approach.
 
I'm not complaining, mind you.  There seems to be a great deal of "assumed
knowledge" on how to interact with the list - so far, I seem to have
(regrettably) made every mistake that can be made.
 
Looking through the MAINTAINERS file gives some global context - is there more
extensive documentation, perhaps a wiki that I've missed, that gives more of the
day-to-day "etiquette"?
 
I've really gotten off on the wrong foot, here, and all I'm trying to accomplish
is to contribute my binutils port for the Open8, so I can move on to finishing
my gcc port.
 
Truly, I wish to conform to the recognized protocols - can someone mentor me,
off list, please?
 
Also, I apologize for the clutter I've injected through my attempts.
 
Kirk Hays 
 
On April 4, 2011 at 9:05 AM Hans-Peter Nilsson <hp@bitrange.com> wrote:

> Re subject, you mean like it's committed in the upstream
> config sources?
>
> On Mon, 4 Apr 2011, Kirk Hays wrote:
>
> > 2011-04-01  Kirk Hays  <khays@hayshaus.com>
> >
> >         * config.sub: From config.git: Add configuration support for Open8
> >         MCU softcore.
>
> If so, then this should be something like "Update from upstream
> sources." as you can see for previous imports. ;)
> (And it should be a full update, not just a patch for your port;
> I don't know if that's what's going on.)
>
> When the changelog instead mentions the specific change, it
> looks like a manual patch which is usually due to a
> misunderstanding of the process, but we've been over that.
>
> brgds, H-P

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]Add support for Open8 configuration to config.sub (from config.git)
  2011-04-04 17:19   ` khays
@ 2011-04-04 18:00     ` Hans-Peter Nilsson
  0 siblings, 0 replies; 4+ messages in thread
From: Hans-Peter Nilsson @ 2011-04-04 18:00 UTC (permalink / raw)
  To: khays; +Cc: binutils

On Mon, 4 Apr 2011, khays@hayshaus.com wrote:
> Given that I don't have checkin privileges (nor should I), I made a guess that
> submitting the change as a patch was the most correct approach.

I'd go with a message to the effect of "Can someone please
import the latest config.sub and config.guess from the upstream
official repo (at where.ever/config.git) which includes support
for my new target, for which I'm about to submit a binutils
port, pretty please?  I'll submit those patches assuming those
imports are in place."

> Looking through the MAINTAINERS file gives some global context - is there more
> extensive documentation, perhaps a wiki that I've missed, that gives more of the
> day-to-day "etiquette"?

Nah, just the mailing list archives.  At least AFAIK.
Asking for instructions ahead of submitting code doesn't hurt either.
Hey, you've already been through the copyright assignment
process, this is the home stretch!

> I've really gotten off on the wrong foot, here,

No, not really.  You haven't been cursing or calling anyone
names, yet. :)  Just not doing things Exactly As Expected.

> and all I'm trying to accomplish
> is to contribute my binutils port for the Open8, so I can move on to finishing
> my gcc port.

(And pardon me for suggesting also doing src/sim and newlib
ports too, so others can verify trivial patches and problems.)

brgds, H-P

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-04-04 18:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-04 15:01 [PATCH]Add support for Open8 configuration to config.sub (from config.git) Kirk Hays
2011-04-04 16:05 ` Hans-Peter Nilsson
2011-04-04 17:19   ` khays
2011-04-04 18:00     ` Hans-Peter Nilsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).