From: Hans-Peter Nilsson <hp@bitrange.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] VAX/BFD: Omit PLT slots for local symbols
Date: Tue, 08 May 2012 04:12:00 -0000 [thread overview]
Message-ID: <alpine.BSF.2.00.1205072358100.61632@dair.pair.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1205072350090.3701@eddie.linux-mips.org>
(Not a maintainer-status review.)
On Tue, 8 May 2012, Maciej W. Rozycki wrote:
> ld/testsuite/
> * ld-vax-elf/plt-local-lib.dd: New test.
> * ld-vax-elf/plt-local-lib.ld: New test linker script.
> * ld-vax-elf/plt-local-lib.s: New test source.
> * ld-vax-elf/plt-local.dd: New test.
> * ld-vax-elf/plt-local.ld:New test linker script.
> * ld-vax-elf/plt-local.s: New test source.
> * ld-vax-elf/plt-local-hidden-pic.s: New test source.
> * ld-vax-elf/plt-local-rehidden-pic.s: New test source.
> * ld-vax-elf/vax-elf.exp: New test script.
> Index: binutils/ld/testsuite/ld-vax-elf/vax-elf.exp
> ===================================================================
> --- /dev/null
> +++ binutils/ld/testsuite/ld-vax-elf/vax-elf.exp
> @@ -0,0 +1,50 @@
> +# Expect script for VAX ELF linker tests
...
> +
> +run_ld_link_tests [list \
> + [list "PLT test (shared library)" \
> + "-shared -T plt-local-lib.ld" \
> + "-k" \
> + { plt-local-lib.s } \
> + { { objdump -d plt-local-lib.dd } } \
> + "plt-local-lib.so"] \
> + [list "PLT test (object 1)" \
> + "-r" \
... (pruned for brevity)
Ouch, another one of those tables-of-lists-of-tables and in a
brand-new .exp.
Let me suggest instead using a mechanism such as run_dump_test
with depended parts (DSO's linked against) sorted before others.
This'd give easy drop-in of new tests without having to add to a
separate table entry somewhere. See ld-cris/cris.exp. Similar
new test: ld-arm/gc-hidden-1.d (unfortunately there's no
file-name iterator in arm-elf.exp, entries are still added
manually).
brgds, H-P
next prev parent reply other threads:[~2012-05-08 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 23:30 Maciej W. Rozycki
2012-05-08 4:12 ` Hans-Peter Nilsson [this message]
2012-07-11 0:04 ` Maciej W. Rozycki
2012-07-11 3:29 ` Hans-Peter Nilsson
2012-07-15 21:57 ` Jan-Benedict Glaw
2012-08-06 10:14 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.00.1205072358100.61632@dair.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).