From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11275 invoked by alias); 8 May 2012 04:12:30 -0000 Received: (qmail 10859 invoked by uid 22791); 8 May 2012 04:12:28 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,TW_BJ X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 08 May 2012 04:12:15 +0000 Received: (qmail 91678 invoked by uid 20157); 8 May 2012 04:12:14 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 8 May 2012 04:12:14 -0000 Date: Tue, 08 May 2012 04:12:00 -0000 From: Hans-Peter Nilsson To: "Maciej W. Rozycki" cc: binutils@sourceware.org Subject: Re: [PATCH] VAX/BFD: Omit PLT slots for local symbols In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00086.txt.bz2 (Not a maintainer-status review.) On Tue, 8 May 2012, Maciej W. Rozycki wrote: > ld/testsuite/ > * ld-vax-elf/plt-local-lib.dd: New test. > * ld-vax-elf/plt-local-lib.ld: New test linker script. > * ld-vax-elf/plt-local-lib.s: New test source. > * ld-vax-elf/plt-local.dd: New test. > * ld-vax-elf/plt-local.ld:New test linker script. > * ld-vax-elf/plt-local.s: New test source. > * ld-vax-elf/plt-local-hidden-pic.s: New test source. > * ld-vax-elf/plt-local-rehidden-pic.s: New test source. > * ld-vax-elf/vax-elf.exp: New test script. > Index: binutils/ld/testsuite/ld-vax-elf/vax-elf.exp > =================================================================== > --- /dev/null > +++ binutils/ld/testsuite/ld-vax-elf/vax-elf.exp > @@ -0,0 +1,50 @@ > +# Expect script for VAX ELF linker tests ... > + > +run_ld_link_tests [list \ > + [list "PLT test (shared library)" \ > + "-shared -T plt-local-lib.ld" \ > + "-k" \ > + { plt-local-lib.s } \ > + { { objdump -d plt-local-lib.dd } } \ > + "plt-local-lib.so"] \ > + [list "PLT test (object 1)" \ > + "-r" \ ... (pruned for brevity) Ouch, another one of those tables-of-lists-of-tables and in a brand-new .exp. Let me suggest instead using a mechanism such as run_dump_test with depended parts (DSO's linked against) sorted before others. This'd give easy drop-in of new tests without having to add to a separate table entry somewhere. See ld-cris/cris.exp. Similar new test: ld-arm/gc-hidden-1.d (unfortunately there's no file-name iterator in arm-elf.exp, entries are still added manually). brgds, H-P