From: Hans-Peter Nilsson <hp@bitrange.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Alan Modra <amodra@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ.
Date: Fri, 19 Mar 2021 13:55:34 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2103191351040.16961@arjuna.pair.com> (raw)
In-Reply-To: <b0e46fde-465a-8884-d3e7-2c441a4a62c1@suse.cz>
On Fri, 19 Mar 2021, Martin Li?ka wrote:
> On 3/19/21 7:37 AM, Alan Modra wrote:
> > On Thu, Mar 18, 2021 at 02:29:26PM -0400, Hans-Peter Nilsson wrote:
> > > How about instead moving and/or making more use of CONST_STRNEQ
> > > from bfd/bfd-in.h?
> >
> > To me the name CONST_STRNEQ just doesn't parse well. Maybe I'm just
> > weird, but I read it as "constant string not equal"
It's not that? :-)
> > which of course is
> > wrong. I much prefer startswith as a name.
>
> No, you're not weird! The function name is weird. To be honest, I noticed
> the function, but the name was so misleading that I ignored it.
>
> > bfd-in.h ought to work
> > for an inline startswith too, since every sysdep.h in binutils already
> > includes string.h, and so too does gas/as.h.
>
> Yes, that's a correct location. I tried placing the new function here, but
> I didn't notice 'make headers' :)
>
> Anyway, as a first step I'm suggesting to do the renaming and I can carry on
> with follow up patches that will use the function more.
FWIW, I don't mind; I'm not even the author, as obvious from my
comment. I just had this hunch that "didn't <name withheld> do
something like this some time ago? Now where *is* that
whatsitsname macro?"
(Maybe CONST_STREQN? Nah... I'm out.)
brgds, H-P
next prev parent reply other threads:[~2021-03-19 17:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 14:20 [PATCH] [RFC] Come up with startswith function Martin Liška
2021-03-18 14:54 ` Tom Tromey
2021-03-18 15:26 ` Martin Liška
2021-03-18 18:00 ` Tom Tromey
2021-03-18 18:29 ` Hans-Peter Nilsson
2021-03-19 6:37 ` Alan Modra
2021-03-19 12:44 ` [PATCH] Add startswith function and use it instead of CONST_STRNEQ Martin Liška
2021-03-19 17:55 ` Hans-Peter Nilsson [this message]
2021-03-20 7:00 ` Alan Modra
2021-03-20 18:58 ` Tom Tromey
2021-03-21 13:12 ` Alan Modra
2021-03-22 2:13 ` Tom Tromey
2021-03-22 12:06 ` Alan Modra
2021-03-22 16:13 ` Luis Machado
2021-03-22 22:56 ` Alan Modra
2021-03-25 10:53 ` Luis Machado
2021-03-25 11:54 ` Alan Modra
2021-03-25 12:05 ` Luis Machado
2021-03-25 19:47 ` Luis Machado
2021-03-25 22:31 ` Mike Frysinger
2021-03-26 11:44 ` Luis Machado
2021-03-30 11:58 ` Luis Machado
2021-03-31 13:12 ` Martin Liška
2021-03-31 13:44 ` Luis Machado
2021-03-22 16:42 ` Martin Liška
2021-03-23 0:02 ` Alan Modra
2021-03-23 4:49 ` Mike Frysinger
2021-03-24 8:19 ` [PATCH 0/5] Start using startswith instead of strncmp Martin Liska
2021-03-18 14:16 ` [PATCH 2/5] Use startswith more for strncmp function calls Martin Liska
2021-03-22 11:12 ` [PATCH 1/5] Replace const_strneq with startswith Martin Liska
2021-03-22 12:33 ` [PATCH 3/5] Use startswith in gas subfolder Martin Liska
2021-03-22 13:56 ` [PATCH 4/5] Remove strneq macro and use startswith Martin Liska
2021-03-23 9:02 ` [PATCH 5/5] Use startswith in gdb subfolder Martin Liska
2021-03-31 20:26 ` Tom Tromey
2021-04-01 5:21 ` [PATCH 0/5] Start using startswith instead of strncmp Martin Liška
2021-04-01 12:47 ` Alan Modra
2021-04-01 13:03 ` Martin Liška
2021-03-31 20:18 ` [PATCH] Add startswith function and use it instead of CONST_STRNEQ Tom Tromey
2021-03-22 6:57 ` Mike Frysinger
2021-03-21 13:19 ` Alan Modra
2021-03-22 10:04 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2103191351040.16961@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).