From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 8FF5C395C03C for ; Fri, 13 May 2022 22:59:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FF5C395C03C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id 42F738A657; Fri, 13 May 2022 18:59:34 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 426218A637; Fri, 13 May 2022 18:59:34 -0400 (EDT) Date: Fri, 13 May 2022 18:59:34 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Huang Pei cc: Zhensong Liu , Chenghua Xu , binutils Subject: Re: [PATCH] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76 In-Reply-To: <20220512023343.3411759-1-huangpei@loongson.cn> Message-ID: References: <20220512023343.3411759-1-huangpei@loongson.cn> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 22:59:35 -0000 The change is IMHO the right thing (I had noticed that commented-out line that didn't look right), but: On Thu, 12 May 2022, Huang Pei wrote: > set elf_backend_default_execstack=0 on loongarch ...may I suggest that "loongarch: Set elf_backend_default_execstack to 0" or "loongarch: Correct elf_backend_default_execstack to 0" is a title better describing the change, than "partial revert ..."? Alan's 5a91f93b9831 patch removed commented-out code (which if un-commented would to what this patch does), so this patch actually doesn't revert that change. brgds, H-P > > Signed-off-by: Huang Pei > --- > bfd/elfnn-loongarch.c | 1 + > ld/testsuite/ld-elf/elf.exp | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c > index 5b44901b9e0..4dcbb44e413 100644 > --- a/bfd/elfnn-loongarch.c > +++ b/bfd/elfnn-loongarch.c > @@ -130,6 +130,7 @@ struct loongarch_elf_link_hash_table > #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 1) > > #define elf_backend_want_dynrelro 1 > +#define elf_backend_default_execstack 0 > > /* Generate a PLT header. */ > > diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp > index ebb5ba090bf..e33a0d08831 100644 > --- a/ld/testsuite/ld-elf/elf.exp > +++ b/ld/testsuite/ld-elf/elf.exp > @@ -186,6 +186,7 @@ proc target_defaults_to_execstack {} { > || [istarget "*-*-nacl"] > || [istarget "arc*-*-*"] > || [istarget "ia64*-*-*"] > + || [istarget "loongarch*-*-*"] > || [istarget "nios2*-*-*"] > || [istarget "powerpc64*-*-*"] > || [istarget "riscv*-*-*"] > -- > 2.20.1 > >