From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hp@bitrange.com>
Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131])
 by sourceware.org (Postfix) with ESMTPS id 9305D3858D37
 for <binutils@sourceware.org>; Wed, 17 Aug 2022 11:29:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9305D3858D37
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=bitrange.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com
Received: by arjuna.pair.com (Postfix, from userid 3006)
 id 9F0098A701; Wed, 17 Aug 2022 07:29:03 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])
 by arjuna.pair.com (Postfix) with ESMTP id 9B7CB8A658;
 Wed, 17 Aug 2022 07:29:03 -0400 (EDT)
Date: Wed, 17 Aug 2022 07:29:03 -0400 (EDT)
From: Hans-Peter Nilsson <hp@bitrange.com>
X-X-Sender: hp@arjuna.pair.com
To: Alan Modra <amodra@gmail.com>
cc: binutils@sourceware.org
Subject: Re: timeout in mmo_get_symbols
In-Reply-To: <YvyT5edFCSvgHNsZ@squeak.grove.modra.org>
Message-ID: <alpine.BSF.2.20.16.2208170725140.20497@arjuna.pair.com>
References: <YvyT5edFCSvgHNsZ@squeak.grove.modra.org>
User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Scanned-By: mailmunge 3.09 on 209.68.5.131
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2022 11:29:09 -0000

Thanks for the fuzzer mmo fixes.
I have to ask, about the subject, "timeout"?
Did this bug perhaps cause an infinite loop with some fuzzed
object?  Is there a story to tell?

On Wed, 17 Aug 2022, Alan Modra via Binutils wrote:

> Fix mmo_get_byte to return a fail-safe value, not just on the first
> call with a read error but on subsequent calls too.

Oopsie! :/

>
> 	* mmo.c (mmo_get_byte): Return the fail-safe value on every
> 	call after a read error.

brgds, H-P