From: Hans-Peter Nilsson <hp@bitrange.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Jan Beulich <jbeulich@suse.com>, binutils@sourceware.org
Subject: Re: [PATCH 1/1] bfd, binutils, gas: Mark unused variables
Date: Thu, 15 Sep 2022 19:10:26 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2209151908480.95175@arjuna.pair.com> (raw)
In-Reply-To: <62b9e3a7-4dcd-40e7-b30f-7cb3776a161d@irq.a4lg.com>
On Thu, 15 Sep 2022, Tsukasa OI via Binutils wrote:
> bfd/mmo.c:
> Likewise (though that "an unimplemented feature" is never
> implemented for over 10 years).
> I want to keep this variable (but may change my mind in the future).
> For bfd/elf32-lm32.c and bfd/mmo.c, I will choose to keep unused
> variables for now. If those variables are still unused in like 2030, I
> will change my mind.
I agree with your assessment regarding mmo.c. :)
The mmo.c change (marking the variable as unused) is fine,
thanks.
brgds, H-P
next prev parent reply other threads:[~2022-09-15 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 3:09 [PATCH 0/1] " Tsukasa OI
2022-09-15 3:09 ` [PATCH 1/1] " Tsukasa OI
2022-09-15 4:17 ` [PATCH 0/1] " Tsukasa OI
2022-09-15 4:17 ` [PATCH 1/1] " Tsukasa OI
2022-09-15 7:29 ` Jan Beulich
2022-09-15 8:25 ` Tsukasa OI
2022-09-15 23:10 ` Hans-Peter Nilsson [this message]
2022-09-15 12:46 ` [PATCH v3 0/1] bfd, binutils, gas: Remove/mark " Tsukasa OI
2022-09-15 12:46 ` [PATCH v3 1/1] " Tsukasa OI
2022-09-15 12:58 ` Jan Beulich
2022-09-20 12:50 ` Nick Clifton
2022-09-21 5:54 ` Tsukasa OI
2022-09-21 6:15 ` Jan Beulich
2022-09-21 9:55 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2209151908480.95175@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).