From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 783A8383A238 for ; Thu, 15 Sep 2022 23:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 783A8383A238 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id D2B6C8A7EC; Thu, 15 Sep 2022 19:10:26 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id D1F278A7EB; Thu, 15 Sep 2022 19:10:26 -0400 (EDT) Date: Thu, 15 Sep 2022 19:10:26 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Tsukasa OI cc: Jan Beulich , binutils@sourceware.org Subject: Re: [PATCH 1/1] bfd, binutils, gas: Mark unused variables In-Reply-To: <62b9e3a7-4dcd-40e7-b30f-7cb3776a161d@irq.a4lg.com> Message-ID: References: <41d8346fa386205b021320b71b3db50898c27bd7.1663215243.git.research_trasio@irq.a4lg.com> <73538f81-579a-d712-9f34-84170a437491@suse.com> <62b9e3a7-4dcd-40e7-b30f-7cb3776a161d@irq.a4lg.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.09 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 15 Sep 2022, Tsukasa OI via Binutils wrote: > bfd/mmo.c: > Likewise (though that "an unimplemented feature" is never > implemented for over 10 years). > I want to keep this variable (but may change my mind in the future). > For bfd/elf32-lm32.c and bfd/mmo.c, I will choose to keep unused > variables for now. If those variables are still unused in like 2030, I > will change my mind. I agree with your assessment regarding mmo.c. :) The mmo.c change (marking the variable as unused) is fine, thanks. brgds, H-P