From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 97E653858407 for ; Sat, 22 Oct 2022 01:44:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97E653858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id 1DA378A836; Fri, 21 Oct 2022 21:44:12 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 1A2DD8A832; Fri, 21 Oct 2022 21:44:12 -0400 (EDT) Date: Fri, 21 Oct 2022 21:44:12 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Tsukasa OI cc: Andrew Burgess , Mike Frysinger , Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH 05/40] cpu/cris: Add u-stall virtual unit to CRIS v32 In-Reply-To: <24baefe92148f4b7968115ba13de9b0c863a65f6.1666257885.git.research_trasio@irq.a4lg.com> Message-ID: References: <24baefe92148f4b7968115ba13de9b0c863a65f6.1666257885.git.research_trasio@irq.a4lg.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.09 on 209.68.5.131 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 20 Oct 2022, Tsukasa OI via Binutils wrote: > Because CRIS v32 model does not define u-stall virtual unit, CGEN-generated > sim/cris/decodev32.h does not define the function declaration of > crisv32f_model_crisv32_u_stall. > > It led to a hack in commit 4e6e8ba7c565 ("sim: cris: clean up missing func > prototype warnings"), manually adding the declaration of > crisv32f_model_crisv32_u_stall. > > To **not** touch CGEN-generated files manually, this commit adds u-stall > virtual unit for CRIS v32 to let CGEN generate the function declaration of > crisv32f_model_crisv32_u_stall automatically. > > This is still hackish but less than the previous one. Why "hackish"? You mean cgen should not hork on not all models defining all the same units even if unused? > cpu/ChangeLog: > > * cris.cpu: Add u-stall virtual unit to CRIS v32. Ok, thanks, with or without a comment above it saying "This unit is not used in CRIS v32 but needs to be defined for CGEN". brgds, H-P