From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id D73743858407 for ; Sat, 22 Oct 2022 01:46:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D73743858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id 7DBD28A741; Fri, 21 Oct 2022 21:46:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 7D1BD8A591; Fri, 21 Oct 2022 21:46:18 -0400 (EDT) Date: Fri, 21 Oct 2022 21:46:18 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Tsukasa OI cc: Andrew Burgess , Mike Frysinger , Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH 06/40] sim/cris: Move declarations of f_specific_init In-Reply-To: <3904a5c3e80f8548150d8088a92059dd728c7ff8.1666257885.git.research_trasio@irq.a4lg.com> Message-ID: References: <3904a5c3e80f8548150d8088a92059dd728c7ff8.1666257885.git.research_trasio@irq.a4lg.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.09 on 209.68.5.131 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 20 Oct 2022, Tsukasa OI via Binutils wrote: > Declarations for MY (f_specific_init) functions are defined in CGEN- > generated header files: sim/cris/decodev10.h (crisv10f_specific_init) and > sim/cris/decodev32.h (crisv32f_specific_init). However, those declarations > are manually added by the commit 4e6e8ba7c565 ("sim: cris: clean up missing > func prototype warnings") as a hack and not a CGEN-generated part. > > Those definitions are required by $(builddir)/sim/cris/mloopv{10,32}f.c, > generated from $(srcdir)/sim/cris/mloop.in. If we define a declaration in > mloop.in, we no longer need manually added one. > > This commit adds a template for function declaration so that we no longer > have to touch CGEN-generated code. With this and the previous commit > "cpu/cris: Add stall unit to CRIS v32", we can now safely regenerate > CRIS CPU declarations with CGEN. > --- > sim/cris/cris-tmpl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sim/cris/cris-tmpl.c b/sim/cris/cris-tmpl.c > index 9f0c06e755e..8694d38b2af 100644 > --- a/sim/cris/cris-tmpl.c > +++ b/sim/cris/cris-tmpl.c > @@ -264,6 +264,8 @@ MY (make_thread_cpu_data) (SIM_CPU *current_cpu, void *context) > > /* Hook function for per-cpu simulator initialization. */ > > +extern void MY (f_specific_init) (SIM_CPU *); > + > void > MY (f_specific_init) (SIM_CPU *current_cpu) > { > -- > 2.34.1 > > Ok, thanks. brgds, H-P