From: Hans-Peter Nilsson <hp@bitrange.com>
To: mengqinggang <mengqinggang@loongson.cn>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2 3/6] LoongArch: opcodes: Add support for linker relaxation.
Date: Wed, 14 Dec 2022 14:21:46 -0500 (EST) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2212141411240.25200@arjuna.pair.com> (raw)
In-Reply-To: <20221213065851.2777297-4-mengqinggang@loongson.cn>
On Tue, 13 Dec 2022, mengqinggang wrote:
> Set gas default to enable relax.
>
> opcodes/ChangeLog:
>
> * loongarch-opc.c (struct loongarch_ASEs_option): New member relax and
> the default value is 1.
Not that ChangeLog entries are required anymore, but seeing this
consistent formatting error hurts my nits. Here and the rest of
your patches:
ChangeLog continuation lines line up with a TAB character to the
"*" on the first line, not the text on that line. Like so:
<TAB>* loongarch-opc.c (struct ...
<TAB>the default value ...
See existing ChangeLog entries.
Also, now that I can take my eyes away from the error, I think
it's "New member relax with the default value 1" but I guess
that's more up to poetic freedom.
brgds, H-P
next prev parent reply other threads:[~2022-12-14 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 6:58 [PATCH v2 0/6] LoongArch linker relaxation support mengqinggang
2022-12-13 6:58 ` [PATCH v2 1/6] LoongArch: include: Add support for linker relaxation mengqinggang
2022-12-13 6:58 ` [PATCH v2 2/6] LoongArch: bfd: " mengqinggang
2022-12-13 6:58 ` [PATCH v2 3/6] LoongArch: opcodes: " mengqinggang
2022-12-14 19:21 ` Hans-Peter Nilsson [this message]
2022-12-13 6:58 ` [PATCH v2 4/6] LoongArch: binutils: " mengqinggang
2022-12-13 6:58 ` [PATCH v2 5/6] LoongArch: gas: " mengqinggang
2022-12-13 6:58 ` [PATCH v2 6/6] LoongArch: ld: " mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2212141411240.25200@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=mengqinggang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).