From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 879843858D1E for ; Tue, 2 May 2023 23:37:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 879843858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id 0071E8A939; Tue, 2 May 2023 19:37:07 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id F3D978A938; Tue, 2 May 2023 19:37:07 -0400 (EDT) Date: Tue, 2 May 2023 19:37:07 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Jan Beulich cc: Binutils Subject: Re: [PATCH v2] gas: equates of registers In-Reply-To: <3a7b6bb3-4ab0-15af-0c74-5d7798ac3793@suse.com> Message-ID: References: <3a7b6bb3-4ab0-15af-0c74-5d7798ac3793@suse.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2 May 2023, Jan Beulich wrote: > There are two problems: symbol_equated_p() doesn't recognize equates of > registers, and S_CAN_BE_REDEFINED() goes by section rather than by > expression type. Both together undermine .eqv and .equiv clearly meaning > to guard the involved symbols against re-definition (both ways). > > To compensate pseudo_set() now using O_symbol and S_CAN_BE_REDEFINED() > now checking for O_register, > - for targets creating register symbols through symbol_{new,create}() -> > symbol_init() -> S_SET_VALUE() (alpha, arc, dlx, ia64, m68k, mips, > mmix, tic4x, tic54x, plus anything using cgen or itbl-ops), have > symbol_init() set their expressions to O_register, (Heads-up for maintainers or asking for approval though being a global maintainer? Anyway...) Ok for mmix iff the binutils test-suites (ld, gas, binutils) shows no regressions for mmix with this patch. brgds, H-P