From: Hans-Peter Nilsson <hp@bitrange.com>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 09/12] objdump/readelf: adjust for SFRAME_VERSION_2
Date: Wed, 28 Jun 2023 19:04:10 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2306281900340.13322@arjuna.pair.com> (raw)
In-Reply-To: <20230627212028.2138604-10-indu.bhagat@oracle.com>
On Tue, 27 Jun 2023, Indu Bhagat via Binutils wrote:
> Make adjustments to account for a new format version and its name.
> Also shuffle some code to make it more readable and use the available
> APIs rather than direct access.
>
> objdump/readelf will show the following message to the user if .sframe
> section in SFRAME_VERSION_1 format is seen:
>
> "No further information can be displayed. SFrame version not
> supported."
>
> In other words, like the rest of the binutils, only the current SFrame
> format version, i.e., SFRAME_VERSION_2 is supported by the textual dump
> facilities.
A decision that IMHO is counter to binutils philosophy (AFAIU),
unless version 1 is actually generated by nobody nowhere.
If there are object files out there generated with version 1,
support should be kept, at the very least for inspection tools.
brgds, H-P
next prev parent reply other threads:[~2023-06-28 23:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 21:20 [PATCH 00/12] SFrame Version 2 - definition and support Indu Bhagat
2023-06-27 21:20 ` [PATCH 01/12] sframe.h: format bump to SFrame version 2 Indu Bhagat
2023-06-27 21:20 ` [PATCH 02/12] gas: generate SFrame section with version SFRAME_VERSION_2 Indu Bhagat
2023-06-27 21:20 ` [PATCH 03/12] libsframe: add new APIs to get SFrame version Indu Bhagat
2023-06-27 21:20 ` [PATCH 04/12] libsframe: add new APIs to add and get SFrame FDE in SFrame version 2 Indu Bhagat
2023-06-27 21:20 ` [PATCH 05/12] libsframe: adjust version check in sframe_header_sanity_check_p Indu Bhagat
2023-06-27 21:20 ` [PATCH 06/12] libsframe: testsuite: fixes for SFRAME_VERSION_2 Indu Bhagat
2023-06-27 21:20 ` [PATCH 07/12] bfd: linker: add support for rep_block_size for pltN entries Indu Bhagat
2023-06-27 21:20 ` [PATCH 08/12] bfd: linker: generate SFrame sections with version SFRAME_VERSION_2 Indu Bhagat
2023-06-27 21:20 ` [PATCH 09/12] objdump/readelf: adjust for SFRAME_VERSION_2 Indu Bhagat
2023-06-28 23:04 ` Hans-Peter Nilsson [this message]
2023-06-29 6:41 ` Indu Bhagat
2023-06-27 21:20 ` [PATCH 10/12] doc: sframe: update specification " Indu Bhagat
2023-06-27 21:20 ` [PATCH 11/12] doc: sframe: add details about alignment in the SFrame format Indu Bhagat
2023-06-27 21:20 ` [PATCH 12/12] binutils/NEWS: announce SFrame version 2 as the new default Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2306281900340.13322@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).