public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Will Hawkins <hawkinsw@obs.cr>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/1] objdump: Add callx support for BPF CPU v1
Date: Fri, 9 Feb 2024 23:47:01 -0500 (EST)	[thread overview]
Message-ID: <alpine.BSF.2.20.16.2402092340010.19305@arjuna.pair.com> (raw)
In-Reply-To: <20240209180734.443763-2-hawkinsw@obs.cr>

On Fri, 9 Feb 2024, Will Hawkins wrote:

> Add support for disassembling the callx instruction back to CPU v1.
> 
> include/ChangeLog:
> 
> 	* opcode/bpf.h (enum bpf_insn_id):
> 
> opcodes/ChangeLog:
> 
> 	* bpf-opc.c:
> 
> ChangeLog:
> 
> 	* sim/bpf/bpf-sim.c (execute):

Not commenting on the rest of the patch but there's missing text 
after ":" above. Beware: gcc/contrib/mklog.py doesn't help with 
that part. :)

Happy hacking!

brgds, H-P

  reply	other threads:[~2024-02-10  4:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 18:07 [PATCH 0/1] " Will Hawkins
2024-02-09 18:07 ` [PATCH 1/1] " Will Hawkins
2024-02-10  4:47   ` Hans-Peter Nilsson [this message]
2024-02-10  6:13     ` Will Hawkins
2024-02-11 23:26       ` Will Hawkins
2024-02-12 17:01 ` [PATCH 0/1] " Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.20.16.2402092340010.19305@arjuna.pair.com \
    --to=hp@bitrange.com \
    --cc=binutils@sourceware.org \
    --cc=hawkinsw@obs.cr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).