From: Hans-Peter Nilsson <hp@bitrange.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Andrew Burgess <aburgess@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH] ld: ensure build-id is placed near ELF headers
Date: Wed, 11 Sep 2024 07:39:02 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2409110735580.43927@arjuna.pair.com> (raw)
In-Reply-To: <d4577ea2-5078-40c6-8e48-134bc59ee52b@redhat.com>
On Wed, 11 Sep 2024, Nick Clifton wrote:
> Hi Hans-Peter,
>
> > > > if test -z "${SEPARATE_CODE}" -o -z
> > > > "${NON_ALLOC_DYN}${SEPARATE_CODE}"; then
> > > > align_text
> > > > fi
> > > >
> >
> > IIRC, "test A -o B" is frowned upon as non-portable, and IIRC
> > mattered for some shell used even in today's day and age.
> >
> > I'd suggest to please use "test A || test B".
>
> Can you use || inside an if-expression (in bash) ? I thought not.
Those are separate commands, not arguments evaluated by "if", so
to speak. (TL;DR: yes)
brgds, H-P
next prev parent reply other threads:[~2024-09-11 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:21 Andrew Burgess
2024-08-19 11:01 ` Nick Clifton
2024-08-21 10:57 ` Andrew Burgess
2024-08-21 20:45 ` Fangrui Song
2024-09-19 15:51 ` Nick Clifton
2024-09-19 20:29 ` H.J. Lu
2024-09-02 10:26 ` Andrew Burgess
2024-09-10 9:01 ` Nick Clifton
2024-09-10 15:38 ` Andrew Burgess
2024-09-10 23:03 ` Hans-Peter Nilsson
2024-09-11 10:42 ` Nick Clifton
2024-09-11 11:39 ` Hans-Peter Nilsson [this message]
2024-09-11 14:11 ` Nick Clifton
2024-09-19 20:53 ` Sam James
2024-09-20 2:52 ` H.J. Lu
2024-09-20 3:45 ` H.J. Lu
2024-09-20 13:20 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2409110735580.43927@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).