From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id DC5793858D21 for ; Fri, 31 Jan 2025 06:02:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC5793858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC5793858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.68.5.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738303346; cv=none; b=sWR4QgpSOb1NuVUSNJLUC4Qy9vbd5rh6hkgQi6qlM6Xy/HBCOeLOTMrEf2FIrO0uxcgKEAGY9G0fx06g2tSfxk5Fypo0M8ocycO4I5wwIeJCbz3GE/ZF9a8/6oAEH6uS/3bcLfDThFom2O3sHA2cMXikiCXd1EE/eNnANhIeEyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738303346; c=relaxed/simple; bh=2CRwmpvsKpoG7W4xpmPQrsCqUFcJNUHtH/88rAZ+SG8=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=HkFmSQZLQ0rLBXAjgdJi8k15JVJwSc1COpvqvtt17BHxIGVF0WlOO+UiGf9obCRiwO/DRLqp5BFmquYW8bzWlskIu4Y18sDxFYwvuEwu6fVwWI5VKELQLne2xRzaszlwOPHC3lClFveLUAp/pkCo4jexZ9FrhSQm24METAQz99M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC5793858D21 Received: by arjuna.pair.com (Postfix, from userid 3006) id 982A18A591; Fri, 31 Jan 2025 01:02:26 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 977808A0CD; Fri, 31 Jan 2025 01:02:26 -0500 (EST) Date: Fri, 31 Jan 2025 01:02:26 -0500 (EST) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Jan Beulich cc: Binutils Subject: Re: [PATCH v2 01/65] gas: consolidate whitespace recognition In-Reply-To: Message-ID: References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.131 X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_40,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SCC_5_SHORT_WORD_LINES,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 27 Jan 2025, Jan Beulich wrote: > --- a/gas/read.c > +++ b/gas/read.c > @@ -112,9 +112,13 @@ die horribly; > > /* Used by is_... macros. our ctype[]. */ > char lex_type[256] = { > - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* @ABCDEFGHIJKLMNO */ > +#ifndef CR_EOL > + 0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 8, 0, 0, /* @ABCDEFGHIJKLMNO */ > +#else > + 0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 0, 0, 0, /* @ABCDEFGHIJKLMNO */ > +#endif > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* PQRSTUVWXYZ[\]^_ */ > - 0, 0, 0, LEX_HASH, LEX_DOLLAR, LEX_PCT, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, /* _!"#$%&'()*+,-./ */ > + 8, 0, 0, LEX_HASH, LEX_DOLLAR, LEX_PCT, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, /* _!"#$%&'()*+,-./ */ > 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, LEX_QM, /* 0123456789:;<=>? */ > LEX_AT, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, /* @ABCDEFGHIJKLMNO */ > 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, LEX_BR, 0, LEX_BR, 0, 3, /* PQRSTUVWXYZ[\]^_ */ Please use LEX_WHITE, not 8. (Columns not lining up is not a valid excuse for naked literals, if that's the claimed reason.) brgds, H-P