From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id B0BC13858D21 for ; Fri, 31 Jan 2025 06:33:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0BC13858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0BC13858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.68.5.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738305204; cv=none; b=nLQdoHXJ87pY+8ZfYRy+TvfQXasLUTwhGGM+MuWeHJypAzlzRFcvxhxR1C1ufNzqJOnOhZzwvwFeqA94lCkv1giGpKUisMAGPBMLEqPyzTjDYT1vCPXJRItHAyCMRkh7IgafGLdFefYfGGv6pLtY+nAa+ClzzuzzzkcwGZ03Vg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738305204; c=relaxed/simple; bh=8rND/Ac1Cyg/tniyfXLDt+8gFFnn7erAeQx6UYp1unI=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=e9TdpliS3ZG70epsoR3QY4yhOacB2cSDANAXIIhQWSgV15EzlYeDHL6Rq6AIIhD4amstDHrk3nxvq5NYd0ThJT0sP3PSm1Jsa281gjzCrSP4KhMnLVMLvu4+v54ugqjfQaZKclzbISulcLa/tKliEiSBFqrmPMsENEnlOiZJMjo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0BC13858D21 Received: by arjuna.pair.com (Postfix, from userid 3006) id 7B53D8A084; Fri, 31 Jan 2025 01:33:24 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 7AD778A0B6; Fri, 31 Jan 2025 01:33:24 -0500 (EST) Date: Fri, 31 Jan 2025 01:33:24 -0500 (EST) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Jan Beulich cc: Binutils Subject: Re: [PATCH v2 32/65] MMIX: use is_whitespace() In-Reply-To: Message-ID: References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 27 Jan 2025, Jan Beulich wrote: > Convert open-coded checks as well as ISSPACE() uses. At the same time > use is_end_of_stmt() instead of open-coded checks; do the conversion > even when not adjacent to code being modified anyway to cover all cases > where the is_end_of_line[] index was wrongly cast from plain char (which > can be signed) to unsigned int. Where is the "wrongly cast" to which you refer? I see no more "wrongly casts" before the patch than after, considering that is_whitespace is doing such a cast. But, I could easily have missed a spot. brgds, H-P