From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id EC1F13858D38 for ; Mon, 3 Feb 2025 06:54:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC1F13858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EC1F13858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.68.5.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738565692; cv=none; b=UDoyGWypuiByUEr8NJdGbsE04PADfyzlAUF4FOznrF5/ZpM4Z/W5Ea0Fm95PkUbsyc24gqTk/z8nKmMfY0vs9G6VlX80NTBVTW/BzW4Qvz507HzCa7RM/iTWeQIjYsPC241CAGda1tU+mFHPP6O0EwVWSGVX2XIXlBjXIOyeGjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738565692; c=relaxed/simple; bh=I3h0HTUEwfXgyAZ5kP1/jZTj3gY5oCBS6lYJ+BwSR/Y=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=WOt+OSJr5QwKFwOwkWon62md8yfaJdcTyMFZqXMJZr55CF76djqfHJKHoqLJpOJD0omUoXBFDg1r1Xpg7ij36lLbJZH+n3LUFDj9mo29GgjKcaoEYSCEzT9xloDNHJmO+mAlYnnSPDvohIawLTqR0DRtrdLViE3MrmookRvDA40= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC1F13858D38 Received: by arjuna.pair.com (Postfix, from userid 3006) id 963F68A028; Mon, 3 Feb 2025 01:54:51 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 934FD8A026; Mon, 3 Feb 2025 01:54:51 -0500 (EST) Date: Mon, 3 Feb 2025 01:54:51 -0500 (EST) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Jan Beulich cc: Binutils Subject: Re: [PATCH v2 32/65] MMIX: use is_whitespace() In-Reply-To: Message-ID: References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 27 Jan 2025, Jan Beulich wrote: > Convert open-coded checks as well as ISSPACE() uses. At the same time > use is_end_of_stmt() instead of open-coded checks; do the conversion > even when not adjacent to code being modified anyway to cover all cases > where the is_end_of_line[] index was wrongly cast from plain char (which > can be signed) to unsigned int. > --- > v2: New. > > --- a/gas/config/tc-mmix.c > +++ b/gas/config/tc-mmix.c Sorry, there are a few hunks that are wrong, like missing a test for ';' and other changes that may work but doesn't logically make sense to me. Most of the stuff like s/ISSPACE/is_whitespace/ is obviously ok, as is of course fixing those horrible (unsigned int) typos. I plan to post a replacement patch (5 hunks differ), but I need to look at it again with fresh eyes so I'll pause it for a day or two. brgds, H-P