From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH][PR ld/10144] MIPS/BFD: Don't make debug section relocs dynamic
Date: Thu, 04 Nov 2010 17:48:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1011041733050.27998@tp.orcam.me.uk> (raw)
In-Reply-To: <g4oca5yp5u.fsf@richards-desktop.stglab.manchester.uk.ibm.com>
On Thu, 4 Nov 2010, Richard Sandiford wrote:
> > My understanding is the base framework just runs */*.exp from within
> > ld/testsuite/ and it is the responsibility of the scripts themselves to
> > filter the targets of concern.
>
> Right. My point was that [istarget mips*-*-linux*] => [is_elf_format];
> we don't support any non-ELF form of GNU/Linux on MIPS. So I wouldn't
> expect to have to check is_elf_format if we're checking the second
> condition as well. I'd still like to see that condition removed.
Good point. This can be added if a need arises from any other targets
added.
> Oh, yeah, much as it pains me to say it: s/favourite/favorite/.
Indeed -- I recall seeing a language convention reference posted to the
list yesterday. As a non-British it may be less of a pain to me, but
still I try to stay consistent with the language I use (I wonder how the
rule is going to play with the style of expression rather than just
spelling, especially when American spelling is mixed with British style).
Oh well... There may be more of such subtleties in some of my outstanding
patches -- I'll try to catch them as I go.
> Anyway, the new comment looks good, thanks. Please install the
> elfxx-mips.c change now. We can apply the testsuite patch once
> the dc.a thing is sorted out.
I am assuming you're trying to minimise the risk of a cross-target
avalanche of failures from the generic test case with the imminent release
in mind; certainly the lone MIPS/n32 misbehaviour (which doesn't trigger a
failure here) cannot justify such an extreme caution.
Thanks for your review; I'm proceeding with the elfxx-mips.c change
straight away.
Maciej
next prev parent reply other threads:[~2010-11-04 17:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 23:31 Maciej W. Rozycki
2010-09-18 8:40 ` Richard Sandiford
2010-11-04 15:09 ` Maciej W. Rozycki
2010-11-04 17:28 ` Richard Sandiford
2010-11-04 17:48 ` Maciej W. Rozycki [this message]
2010-11-10 17:16 ` Richard Sandiford
2010-11-10 17:58 ` Maciej W. Rozycki
2010-11-11 0:27 ` Matthias Klose
2010-11-11 1:44 ` Maciej W. Rozycki
2010-11-11 10:11 ` Richard Sandiford
2010-11-12 17:39 ` Maciej W. Rozycki
2010-11-15 8:32 ` Alan Modra
2010-12-07 20:27 ` Maciej W. Rozycki
2010-12-09 21:20 ` Richard Sandiford
2010-12-10 14:32 ` Maciej W. Rozycki
2010-12-11 10:21 ` Richard Sandiford
2010-12-13 16:51 ` Maciej W. Rozycki
2011-10-31 12:22 ` Maciej W. Rozycki
2011-11-24 20:59 ` Richard Sandiford
2011-11-29 12:43 ` Maciej W. Rozycki
2011-12-01 2:52 ` Fix CRIS bug exposed by "MIPS/BFD: Don't make debug section relocs dynamic" Hans-Peter Nilsson
2011-12-01 8:14 ` Tristan Gingold
2011-12-01 10:46 ` Mikael Pettersson
2011-12-01 15:52 ` nick clifton
2011-12-02 8:12 ` Tristan Gingold
2011-12-02 12:12 ` Hans-Peter Nilsson
2011-12-02 12:50 ` Tristan Gingold
2011-12-02 13:39 ` Hans-Peter Nilsson
2012-02-15 23:03 ` [PATCH] de-Linuxification Thomas Schwinge
2012-02-20 1:53 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1011041733050.27998@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).