From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: Catherine Moore <clm@codesourcery.com>, binutils@sourceware.org
Subject: [PATCH 10/20] MIPS/GAS: Fail on 64-bit addresses used with LI
Date: Thu, 02 Dec 2010 19:20:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1012020114000.14129@tp.orcam.me.uk> (raw)
Hi,
This change adds a suitable assertion to the LI macro where 64-bit
addresses are not expected and not handled correctly.
2010-12-02 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (macro)[M_LI_DD]: Fail if a 64-bit address is
truncated to 32 bits.
OK to apply?
Maciej
binutils-gas-mips-lidd-assert.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-01 21:05:50.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-01 21:05:51.000000000 +0000
@@ -7039,6 +7039,7 @@ macro (struct mips_cl_insn *ip)
else
{
/* FIXME: This won't work for a 64 bit address. */
+ gas_assert (HAVE_32BIT_ADDRESSES);
macro_build_lui (&offset_expr, AT);
}
next reply other threads:[~2010-12-02 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 19:20 Maciej W. Rozycki [this message]
2010-12-07 10:25 ` Richard Sandiford
2010-12-09 16:09 ` Maciej W. Rozycki
2010-12-09 17:41 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1012020114000.14129@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=clm@codesourcery.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).