From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15608 invoked by alias); 2 Dec 2010 23:57:16 -0000 Received: (qmail 15600 invoked by uid 22791); 2 Dec 2010 23:57:15 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Dec 2010 23:57:11 +0000 Received: (qmail 12379 invoked from network); 2 Dec 2010 23:57:09 -0000 Received: from unknown (HELO tp.orcam.me.uk) (macro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Dec 2010 23:57:09 -0000 Date: Thu, 02 Dec 2010 23:57:00 -0000 From: "Maciej W. Rozycki" To: Paul Koning cc: binutils@sourceware.org Subject: Re: [PATCH 04/20] MIPS/GAS: Spell out 0 referring to $0 as ZERO In-Reply-To: <287DBDC3-A48A-4733-BF12-A8EBE7C1E2DA@dell.com> Message-ID: References: <287DBDC3-A48A-4733-BF12-A8EBE7C1E2DA@dell.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00139.txt.bz2 On Thu, 2 Dec 2010, Paul Koning wrote: > > Here is a (supposedly) exhaustive change to macro() that makes $0 > > register references in macro_build() and move_register() calls to be > > spelled as ZERO for better clarity and difference to places where an > > immediate value of 0 is referred to. I have not changed other places, > > typically pieces of code like: > > > > treg = 0; > > > > or: > > > > if (sreg == 0) > > > > whose reference to $0 is obvious. > > I wouldn't say those are a whole lot more obvious than the ones you did > change... These variables refer to registers and their names make it unambiguous, but feel free to propose a follow-on patch -- I won't object such a change. Maciej