From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23962 invoked by alias); 10 Dec 2010 00:38:32 -0000 Received: (qmail 23951 invoked by uid 22791); 10 Dec 2010 00:38:32 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Dec 2010 00:38:27 +0000 Received: (qmail 22290 invoked from network); 10 Dec 2010 00:38:25 -0000 Received: from unknown (HELO tp.orcam.me.uk) (macro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Dec 2010 00:38:25 -0000 Date: Fri, 10 Dec 2010 00:38:00 -0000 From: "Maciej W. Rozycki" To: Richard Sandiford cc: Catherine Moore , binutils@sourceware.org Subject: Re: [PATCH 20/20] MIPS/GAS: Remove dead format specifier code In-Reply-To: <87bp4xajvo.fsf@firetop.home> Message-ID: References: <87bp4xajvo.fsf@firetop.home> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00371.txt.bz2 On Tue, 7 Dec 2010, Richard Sandiford wrote: > > gas/ > > * config/tc-mips.c (mips_ip): Remove dead format specifier code. > > OK, thanks. I wonder if the 'G' confusion came from someone misinterpreting: > > if (ok) > { > lastregno = regno; > continue; > } > else > break; > > as fallthrough? Yes, this well could be indeed, good point. I haven't thought about this arrangement being a possible cause. Another possibility is simply a remnant from before cooked CP0 register names were introduced -- I would expect 'G' to have been handled like 'd' back then without dedicated outermost switch statement's case code. > if (ok) > { > lastregno = regno; > continue; > } > break; > > would be more usual. Maybe I'll tweak it after the microMIPS stuff > has gone in. Well, I have actually removed the oddity with the microMIPS patch as the case had to be heavily tweaked anyway. I also removed a couple of similar oddities, where a "break" or "continue" was included at the end in a block rather than following it within the microMIPS patch itself, but I have just noticed a couple escaped me. I'll clean them up as well as they may make one wonder if the closing brace is the end of a (misindented) compound selection or iteration statement. Maciej