From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: binutils@sourceware.org
Cc: Richard Sandiford <rdsandiford@googlemail.com>
Subject: [committed] MIPS/GAS: Remove duplicate initialisation of offset_reloc
Date: Mon, 21 Feb 2011 23:27:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1102212230550.20460@tp.orcam.me.uk> (raw)
Hello,
The change below removes duplicate initialisation of offset_reloc
currently made in the handler of the 'o' format specifier. There is
exactly the same sequence of three assignments repeated immediately before
the comment seen in the patch below (and the comment applies to the
conditional).
Committed as obvious.
2011-02-21 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (mips_ip) <'o'>: Remove duplicate
initialization of offset_reloc.
Maciej
binutils-gas-mips-fix-offset-reloc.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2011-02-21 21:33:26.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2011-02-21 21:34:04.000000000 +0000
@@ -11907,9 +11907,6 @@ mips_ip (char *str, struct mips_cl_insn
/* Check whether there is only a single bracketed expression
left. If so, it must be the base register and the
constant must be zero. */
- offset_reloc[0] = BFD_RELOC_LO16;
- offset_reloc[1] = BFD_RELOC_UNUSED;
- offset_reloc[2] = BFD_RELOC_UNUSED;
if (*s == '(' && strchr (s + 1, '(') == 0)
{
offset_expr.X_op = O_constant;
reply other threads:[~2011-02-21 23:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1102212230550.20460@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).