* [committed] MIPS/GAS: Remove duplicate initialisation of offset_reloc
@ 2011-02-21 23:27 Maciej W. Rozycki
0 siblings, 0 replies; only message in thread
From: Maciej W. Rozycki @ 2011-02-21 23:27 UTC (permalink / raw)
To: binutils; +Cc: Richard Sandiford
Hello,
The change below removes duplicate initialisation of offset_reloc
currently made in the handler of the 'o' format specifier. There is
exactly the same sequence of three assignments repeated immediately before
the comment seen in the patch below (and the comment applies to the
conditional).
Committed as obvious.
2011-02-21 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (mips_ip) <'o'>: Remove duplicate
initialization of offset_reloc.
Maciej
binutils-gas-mips-fix-offset-reloc.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2011-02-21 21:33:26.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2011-02-21 21:34:04.000000000 +0000
@@ -11907,9 +11907,6 @@ mips_ip (char *str, struct mips_cl_insn
/* Check whether there is only a single bracketed expression
left. If so, it must be the base register and the
constant must be zero. */
- offset_reloc[0] = BFD_RELOC_LO16;
- offset_reloc[1] = BFD_RELOC_UNUSED;
- offset_reloc[2] = BFD_RELOC_UNUSED;
if (*s == '(' && strchr (s + 1, '(') == 0)
{
offset_expr.X_op = O_constant;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-02-21 23:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-21 23:27 [committed] MIPS/GAS: Remove duplicate initialisation of offset_reloc Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).