From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7336 invoked by alias); 21 Feb 2011 23:27:24 -0000 Received: (qmail 7328 invoked by uid 22791); 21 Feb 2011 23:27:23 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_50,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 23:27:19 +0000 Received: (qmail 28852 invoked from network); 21 Feb 2011 23:27:17 -0000 Received: from unknown (HELO tp.orcam.me.uk) (macro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Feb 2011 23:27:17 -0000 Date: Mon, 21 Feb 2011 23:27:00 -0000 From: "Maciej W. Rozycki" To: binutils@sourceware.org cc: Richard Sandiford Subject: [committed] MIPS/GAS: Remove duplicate initialisation of offset_reloc Message-ID: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00265.txt.bz2 Hello, The change below removes duplicate initialisation of offset_reloc currently made in the handler of the 'o' format specifier. There is exactly the same sequence of three assignments repeated immediately before the comment seen in the patch below (and the comment applies to the conditional). Committed as obvious. 2011-02-21 Maciej W. Rozycki gas/ * config/tc-mips.c (mips_ip) <'o'>: Remove duplicate initialization of offset_reloc. Maciej binutils-gas-mips-fix-offset-reloc.diff Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c =================================================================== --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2011-02-21 21:33:26.000000000 +0000 +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2011-02-21 21:34:04.000000000 +0000 @@ -11907,9 +11907,6 @@ mips_ip (char *str, struct mips_cl_insn /* Check whether there is only a single bracketed expression left. If so, it must be the base register and the constant must be zero. */ - offset_reloc[0] = BFD_RELOC_LO16; - offset_reloc[1] = BFD_RELOC_UNUSED; - offset_reloc[2] = BFD_RELOC_UNUSED; if (*s == '(' && strchr (s + 1, '(') == 0) { offset_expr.X_op = O_constant;