* [PATCH] MIPS/GAS/testsuite: Fix microMIPS loc-swap-2 regression
@ 2011-10-24 14:33 Maciej W. Rozycki
2011-11-17 18:46 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2011-10-24 14:33 UTC (permalink / raw)
To: Richard Sandiford; +Cc: binutils
Hi Richard,
Your recent change has introduced a DWARF-2 test that unfortunately fails
for microMIPS code, both for the Linux and the ELF target. I have
investigated the records reported and it's the test patterns that are
incorrect -- it looks like you've made your dump with a setup where the
first MOVE instruction in the corresponding source file was not swapped
with the following branch.
Here's an updated dump, that corrects the regression. OK to apply?
2011-10-24 Maciej W. Rozycki <macro@codesourcery.com>
gas/testsuite/
* gas/mips/micromips@loc-swap-2.d: Correct test case.
Maciej
binutils-gas-test-umips-loc-swap-fix.diff
Index: binutils-fsf-trunk-quilt/gas/testsuite/gas/mips/micromips@loc-swap-2.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/testsuite/gas/mips/micromips@loc-swap-2.d 2011-10-24 14:48:39.395881474 +0100
+++ binutils-fsf-trunk-quilt/gas/testsuite/gas/mips/micromips@loc-swap-2.d 2011-10-24 14:49:15.965890139 +0100
@@ -39,11 +39,11 @@
Line Number Statements:
Extended opcode 2: set Address to 0x1
Special opcode 11: advance Address by 0 to 0x1 and Line by 6 to 7
- Special opcode 35: advance Address by 2 to 0x3 and Line by 2 to 9
- Special opcode 6: advance Address by 0 to 0x3 and Line by 1 to 10
- Special opcode 64: advance Address by 4 to 0x7 and Line by 3 to 13
- Special opcode 34: advance Address by 2 to 0x9 and Line by 1 to 14
- Special opcode 6: advance Address by 0 to 0x9 and Line by 1 to 15
- Special opcode 63: advance Address by 4 to 0xd and Line by 2 to 17
- Advance PC by 1 to 0xe
+ Special opcode 7: advance Address by 0 to 0x1 and Line by 2 to 9
+ Special opcode 6: advance Address by 0 to 0x1 and Line by 1 to 10
+ Special opcode 64: advance Address by 4 to 0x5 and Line by 3 to 13
+ Special opcode 34: advance Address by 2 to 0x7 and Line by 1 to 14
+ Special opcode 6: advance Address by 0 to 0x7 and Line by 1 to 15
+ Special opcode 63: advance Address by 4 to 0xb and Line by 2 to 17
+ Advance PC by 1 to 0xc
Extended opcode 1: End of Sequence
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/GAS/testsuite: Fix microMIPS loc-swap-2 regression
2011-10-24 14:33 [PATCH] MIPS/GAS/testsuite: Fix microMIPS loc-swap-2 regression Maciej W. Rozycki
@ 2011-11-17 18:46 ` Richard Sandiford
2011-11-21 11:13 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2011-11-17 18:46 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: binutils
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> 2011-10-24 Maciej W. Rozycki <macro@codesourcery.com>
>
> gas/testsuite/
> * gas/mips/micromips@loc-swap-2.d: Correct test case.
OK.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/GAS/testsuite: Fix microMIPS loc-swap-2 regression
2011-11-17 18:46 ` Richard Sandiford
@ 2011-11-21 11:13 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2011-11-21 11:13 UTC (permalink / raw)
To: Richard Sandiford; +Cc: binutils
On Thu, 17 Nov 2011, Richard Sandiford wrote:
> > 2011-10-24 Maciej W. Rozycki <macro@codesourcery.com>
> >
> > gas/testsuite/
> > * gas/mips/micromips@loc-swap-2.d: Correct test case.
>
> OK.
Thanks, committed now.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-21 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-24 14:33 [PATCH] MIPS/GAS/testsuite: Fix microMIPS loc-swap-2 regression Maciej W. Rozycki
2011-11-17 18:46 ` Richard Sandiford
2011-11-21 11:13 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).