From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2798 invoked by alias); 1 Aug 2012 18:20:28 -0000 Received: (qmail 2763 invoked by uid 22791); 1 Aug 2012 18:20:25 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Aug 2012 18:20:12 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SwdWk-000306-Cg from Maciej_Rozycki@mentor.com ; Wed, 01 Aug 2012 11:20:10 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 1 Aug 2012 11:20:10 -0700 Received: from [172.30.4.177] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Wed, 1 Aug 2012 19:20:08 +0100 Date: Wed, 01 Aug 2012 18:20:00 -0000 From: "Maciej W. Rozycki" To: Richard Sandiford , Alan Modra CC: Subject: Re: [PATCH] MIPS: Enable NewABI tests for SDE targets In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00024.txt.bz2 Hi, > gas/testsuite/ > * gas/mips/mips.exp: Set has_newabi for mips*-sde-elf* too. > * gas/mips/elf-rel-got-n32.s: Adjust padding. > * gas/mips/elf-rel-got-n64.s: Likewise. > * gas/mips/elf-rel23.s: Likewise. > * gas/mips/elf-rel28.s: Likewise. > * gas/mips/n32-consec.s: Likewise. > * gas/mips/elf-rel-xgot-n32.d: Adjust output expected. > * gas/mips/elf-rel-xgot-n64.d: Likewise. > * gas/mips/elf-rel23.d: Likewise. > * gas/mips/elf-rel23a.d: Likewise. > * gas/mips/elf-rel23b.d: Likewise. > * gas/mips/elf-rel28-n32.d: Likewise. > > ld/testsuite/ > * ld-mips-elf/emit-relocs-1a.s: Make section alignment uniform > across targets. > * ld-mips-elf/emit-relocs-1b.s: Likewise. > * ld-mips-elf/jalbal.s: Adjust padding. > * ld-mips-elf/elf-rel-got-n32-embed.d: New test. > * ld-mips-elf/elf-rel-got-n64-embed.d: New test. > * ld-mips-elf/elf-rel-xgot-n32-embed.d: New test. > * ld-mips-elf/elf-rel-xgot-n64-embed.d: New test. > * ld-mips-elf/elf-rel-got-n32.d: Remove -melf32btsmipn32. > * ld-mips-elf/elf-rel-got-n64.d: Remove -melf64btsmip. Adjust > output. > * ld-mips-elf/elf-rel-got-n64-linux.d: Remove -melf64btsmip. > * ld-mips-elf/elf-rel-xgot-n32.d: Remove -melf32btsmipn32. > Adjust output. > * ld-mips-elf/elf-rel-xgot-n64.d: Remove -melf64btsmip. Adjust > output. > * ld-mips-elf/elf-rel-xgot-n64-linux.d: Likewise. > * ld-mips-elf/reloc-1-n64.d: Remove -melf64btsmip. > * ld-mips-elf/mips-elf.exp: Set has_newabi for mips*-sde-elf* > too. Move tool flags from o32_as_flags and o32_ld_flags > variables into abi_asflags and abi_ldflags arrays. Adjust test > cases run to use them. Run the new tests. > * lib/ld-lib.exp (run_dump_test): Implement the EXTRA_OPTIONS > argument and the "dump" keyword. Regrettably the next change I was about to submit uncovered a couple of regressions affecting little-endian targets. They are fixed with the update below. No further issues found. I have further widened MIPS target coverage now. For the record -- I'll be testing these MIPS targets with submissions from now on: mips-ecoff mips-elf mips-sde-elf mips-sgi-irix5 mips-sgi-irix6 mips-freebsd mips-linux mips64-freebsd mips64-linux mips64el-freebsd mips64el-linux mipsel-ecoff mipsel-elf mipsel-freebsd mipsel-linux mipsisa32-elf mipsisa32-linux mipsisa32el-elf mipsisa32el-linux mipsisa64-elf mipsisa64-linux mipsisa64el-elf mipsisa64el-linux -- have I missed anything important here? 2012-08-01 Maciej W. Rozycki ld/testsuite/ * ld-mips-elf/reloc-1-n32.d: Add -EB to GAS flags. No need to update mips-elf.exp's entry as the update is intended to be merged with the original change. Maciej binutils-mips-sde-test-newabi-el.diff Index: binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/mips-elf.exp =================================================================== --- binutils-fsf-trunk-quilt.orig/ld/testsuite/ld-mips-elf/mips-elf.exp 2012-08-01 17:20:56.000000000 +0100 +++ binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/mips-elf.exp 2012-08-01 17:41:53.621165721 +0100 @@ -357,14 +357,14 @@ if { $has_newabi } { [list \ "reloc test 6a" \ "-shared $abi_ldflags(n32)" \ - "-n32" \ + "$abi_asflags(n32)" \ "reloc-6a.s" \ {} \ "reloc-6a.so"] \ [list \ "reloc test 6b" \ "$abi_ldflags(n32) tmpdir/reloc-6a.so" \ - "-n32" \ + "$abi_asflags(n32)" \ "reloc-6b.s" \ {} \ "reloc-6b"]] Index: binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/reloc-1-n32.d =================================================================== --- binutils-fsf-trunk-quilt.orig/ld/testsuite/ld-mips-elf/reloc-1-n32.d 2012-07-21 05:03:06.000000000 +0100 +++ binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/reloc-1-n32.d 2012-08-01 17:40:56.580512731 +0100 @@ -1,5 +1,5 @@ -#source: reloc-1a.s -mabi=n32 -#source: reloc-1b.s -mabi=n32 +#source: reloc-1a.s -mabi=n32 -EB +#source: reloc-1b.s -mabi=n32 -EB #ld: -r #readelf: --relocs