From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: <binutils@sourceware.org>
Cc: Richard Sandiford <rdsandiford@googlemail.com>,
<gdb-patches@sourceware.org>
Subject: [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP
Date: Thu, 02 Aug 2012 16:15:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1208021712110.20608@tp.orcam.me.uk> (raw)
Hi,
It is not true (anymore?) that GDB only looks at the first of DT_DEBUG,
DT_MIPS_RLD_MAP dynamic tags it encounters. Here's an update to the
comment around related code. OK to apply?
2012-08-02 Maciej W. Rozycki <macro@codesourcery.com>
bfd/
* elfxx-mips.c (_bfd_mips_elf_size_dynamic_sections): Update the
comment on DT_MIPS_RLD_MAP.
Maciej
binutils-bfd-mips-rld-map.diff
Index: binutils-fsf-trunk-quilt/bfd/elfxx-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/elfxx-mips.c 2012-07-26 02:30:35.181780745 +0100
+++ binutils-fsf-trunk-quilt/bfd/elfxx-mips.c 2012-07-26 02:30:37.681785764 +0100
@@ -9180,8 +9180,8 @@ _bfd_mips_elf_size_dynamic_sections (bfd
/* SGI object has the equivalence of DT_DEBUG in the
DT_MIPS_RLD_MAP entry. This must come first because glibc
- only fills in DT_MIPS_RLD_MAP (not DT_DEBUG) and GDB only
- looks at the first one it sees. */
+ only fills in DT_MIPS_RLD_MAP (not DT_DEBUG) and some tools
+ may only look at the first one they see. */
if (!info->shared
&& !MIPS_ELF_ADD_DYNAMIC_ENTRY (info, DT_MIPS_RLD_MAP, 0))
return FALSE;
next reply other threads:[~2012-08-02 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 16:15 Maciej W. Rozycki [this message]
2012-08-02 18:48 ` Richard Sandiford
2012-08-03 22:15 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1208021712110.20608@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).