From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-76457-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 22984 invoked by alias); 2 Aug 2012 16:15:57 -0000
Received: (qmail 22955 invoked by uid 22791); 2 Aug 2012 16:15:50 -0000
X-SWARE-Spam-Status: No, hits=-3.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_FX
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Aug 2012 16:15:37 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1Swy3l-00012t-Bv from Maciej_Rozycki@mentor.com ; Thu, 02 Aug 2012 09:15:37 -0700
Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Thu, 2 Aug 2012 09:15:37 -0700
Received: from [172.30.4.177] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Thu, 2 Aug 2012 17:15:35 +0100
Date: Thu, 02 Aug 2012 16:15:00 -0000
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: <binutils@sourceware.org>
CC: Richard Sandiford <rdsandiford@googlemail.com>,	<gdb-patches@sourceware.org>
Subject: [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP
Message-ID: <alpine.DEB.1.10.1208021712110.20608@tp.orcam.me.uk>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00033.txt.bz2

Hi,

 It is not true (anymore?) that GDB only looks at the first of DT_DEBUG, 
DT_MIPS_RLD_MAP dynamic tags it encounters.  Here's an update to the 
comment around related code.  OK to apply?

2012-08-02  Maciej W. Rozycki  <macro@codesourcery.com>

	bfd/
	* elfxx-mips.c (_bfd_mips_elf_size_dynamic_sections): Update the
	comment on DT_MIPS_RLD_MAP.

  Maciej

binutils-bfd-mips-rld-map.diff
Index: binutils-fsf-trunk-quilt/bfd/elfxx-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/elfxx-mips.c	2012-07-26 02:30:35.181780745 +0100
+++ binutils-fsf-trunk-quilt/bfd/elfxx-mips.c	2012-07-26 02:30:37.681785764 +0100
@@ -9180,8 +9180,8 @@ _bfd_mips_elf_size_dynamic_sections (bfd
 
       /* SGI object has the equivalence of DT_DEBUG in the
 	 DT_MIPS_RLD_MAP entry.  This must come first because glibc
-	 only fills in DT_MIPS_RLD_MAP (not DT_DEBUG) and GDB only
-	 looks at the first one it sees.  */
+	 only fills in DT_MIPS_RLD_MAP (not DT_DEBUG) and some tools
+	 may only look at the first one they see.  */
       if (!info->shared
 	  && !MIPS_ELF_ADD_DYNAMIC_ENTRY (info, DT_MIPS_RLD_MAP, 0))
 	return FALSE;