* [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP
@ 2012-08-02 16:15 Maciej W. Rozycki
2012-08-02 18:48 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2012-08-02 16:15 UTC (permalink / raw)
To: binutils; +Cc: Richard Sandiford, gdb-patches
Hi,
It is not true (anymore?) that GDB only looks at the first of DT_DEBUG,
DT_MIPS_RLD_MAP dynamic tags it encounters. Here's an update to the
comment around related code. OK to apply?
2012-08-02 Maciej W. Rozycki <macro@codesourcery.com>
bfd/
* elfxx-mips.c (_bfd_mips_elf_size_dynamic_sections): Update the
comment on DT_MIPS_RLD_MAP.
Maciej
binutils-bfd-mips-rld-map.diff
Index: binutils-fsf-trunk-quilt/bfd/elfxx-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/elfxx-mips.c 2012-07-26 02:30:35.181780745 +0100
+++ binutils-fsf-trunk-quilt/bfd/elfxx-mips.c 2012-07-26 02:30:37.681785764 +0100
@@ -9180,8 +9180,8 @@ _bfd_mips_elf_size_dynamic_sections (bfd
/* SGI object has the equivalence of DT_DEBUG in the
DT_MIPS_RLD_MAP entry. This must come first because glibc
- only fills in DT_MIPS_RLD_MAP (not DT_DEBUG) and GDB only
- looks at the first one it sees. */
+ only fills in DT_MIPS_RLD_MAP (not DT_DEBUG) and some tools
+ may only look at the first one they see. */
if (!info->shared
&& !MIPS_ELF_ADD_DYNAMIC_ENTRY (info, DT_MIPS_RLD_MAP, 0))
return FALSE;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP
2012-08-02 16:15 [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP Maciej W. Rozycki
@ 2012-08-02 18:48 ` Richard Sandiford
2012-08-03 22:15 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2012-08-02 18:48 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: binutils, gdb-patches
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> It is not true (anymore?) that GDB only looks at the first of DT_DEBUG,
> DT_MIPS_RLD_MAP dynamic tags it encounters. Here's an update to the
> comment around related code. OK to apply?
OK, thanks.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP
2012-08-02 18:48 ` Richard Sandiford
@ 2012-08-03 22:15 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2012-08-03 22:15 UTC (permalink / raw)
To: Richard Sandiford; +Cc: binutils, gdb-patches
On Thu, 2 Aug 2012, Richard Sandiford wrote:
> > It is not true (anymore?) that GDB only looks at the first of DT_DEBUG,
> > DT_MIPS_RLD_MAP dynamic tags it encounters. Here's an update to the
> > comment around related code. OK to apply?
>
> OK, thanks.
Committed now, thanks.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-03 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-02 16:15 [PATCH] MIPS/BFD: Adjust the comment about DT_MIPS_RLD_MAP Maciej W. Rozycki
2012-08-02 18:48 ` Richard Sandiford
2012-08-03 22:15 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).