public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: Alan Modra <amodra@gmail.com>, <binutils@sourceware.org>
Subject: Re: [PATCH] MIPS: Enable NewABI tests for SDE targets
Date: Mon, 06 Aug 2012 21:39:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1208062206090.20608@tp.orcam.me.uk> (raw)
In-Reply-To: <87hasina84.fsf@talisman.home>

On Sat, 4 Aug 2012, Richard Sandiford wrote:

> >  A list of lists seems more in the spirit of TCL to me, while a vector is 
> > more C-like
> 
> Not sure about that.  "foreach { a b .. } ..." is provided exactly to make
> flat lists easy to handle.  [string map ...] takes a flat list rather than
> a list of lists.  Flat lists are also what is used by [array set ...]
> and [array get ...], so that one easy way of handling unordered key-value
> list arguments is:
> 
>     array set foo $argument
>     if { [info exists $foo(key)] } ...
> 
> If you're lucky enough to be able to rely on Tcl 8.5, then dict operates
> in just the same way.  Flat lists can even be used as dicts directly,
> without any conversion.
> 
> I don't know of any native Tcl operation that uses lists of lists instead.

 They're easily traversed and many examples in the reference manual use 
nested lists, but your arguments sound convincing to me, I agree.

> > However please note that implementing your suggestion will make the
> > two run_dump_test implementations confusingly different -- do you
> > still want me to proceed?
> 
> That's a clincher though.  Please go with your original patch.

 I have therefore applied it now (and the update, although separately, 
sorry about that), thanks for your review.  Let's wait for some rainy 
evening to get the two procedures converted to a flat list.

  Maciej

      reply	other threads:[~2012-08-06 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01 14:43 Maciej W. Rozycki
2012-08-01 18:20 ` Maciej W. Rozycki
2012-08-02 18:39 ` Richard Sandiford
2012-08-03 21:46   ` Maciej W. Rozycki
2012-08-04 12:07     ` Richard Sandiford
2012-08-06 21:39       ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1208062206090.20608@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).