From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18300 invoked by alias); 6 Aug 2012 21:24:47 -0000 Received: (qmail 18274 invoked by uid 22791); 6 Aug 2012 21:24:44 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Aug 2012 21:24:27 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SyUmp-0003HL-6m from Maciej_Rozycki@mentor.com ; Mon, 06 Aug 2012 14:24:27 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 6 Aug 2012 14:24:27 -0700 Received: from [172.30.4.68] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Mon, 6 Aug 2012 22:24:25 +0100 Date: Mon, 06 Aug 2012 21:39:00 -0000 From: "Maciej W. Rozycki" To: Richard Sandiford CC: Alan Modra , Subject: Re: [PATCH] MIPS: Enable NewABI tests for SDE targets In-Reply-To: <87hasina84.fsf@talisman.home> Message-ID: References: <87ipd1nnpb.fsf@talisman.home> <87hasina84.fsf@talisman.home> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00109.txt.bz2 On Sat, 4 Aug 2012, Richard Sandiford wrote: > > A list of lists seems more in the spirit of TCL to me, while a vector is > > more C-like > > Not sure about that. "foreach { a b .. } ..." is provided exactly to make > flat lists easy to handle. [string map ...] takes a flat list rather than > a list of lists. Flat lists are also what is used by [array set ...] > and [array get ...], so that one easy way of handling unordered key-value > list arguments is: > > array set foo $argument > if { [info exists $foo(key)] } ... > > If you're lucky enough to be able to rely on Tcl 8.5, then dict operates > in just the same way. Flat lists can even be used as dicts directly, > without any conversion. > > I don't know of any native Tcl operation that uses lists of lists instead. They're easily traversed and many examples in the reference manual use nested lists, but your arguments sound convincing to me, I agree. > > However please note that implementing your suggestion will make the > > two run_dump_test implementations confusingly different -- do you > > still want me to proceed? > > That's a clincher though. Please go with your original patch. I have therefore applied it now (and the update, although separately, sorry about that), thanks for your review. Let's wait for some rainy evening to get the two procedures converted to a flat list. Maciej