public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: <binutils@sourceware.org>
Subject: Re: [PATCH] MIPS: Enable NewABI testing for all Linux targets
Date: Fri, 10 Aug 2012 13:19:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1208100248280.20608@tp.orcam.me.uk> (raw)
In-Reply-To: <878vdrjhz8.fsf@talisman.home>

On Tue, 7 Aug 2012, Richard Sandiford wrote:

> >> Not including the targets in the BFD64 block at the time that the
> >> extra vectors were added was probably an oversight.
> >
> >  I've been wondering if these extra vectors were added by mistake instead, 
> > like slipped through in a larger commit unnoticed.  I'll post a fix to the 
> > BFD64 block separately.
> 
> The 64-bit ones?  No, Debian wanted to allow 32-bit *-linux-gnu targets
> that provice all three ABIs, while still defaulting to o32.  The associated
> GCC configure option is --enable-targets=all.  (Confusingly different from
> the binutils meaning, but there you go.  That choice of name wasn't a MIPS
> invention.)

 OK, thanks for this background information.  Here's the change I 
promised, no regressions on the 23 MIPS targets.  OK to apply?

  Maciej

2012-08-10  Maciej W. Rozycki  <macro@codesourcery.com>

	bfd/
	* config.bfd: Wrap mips*-*-linux* and mips*el-*-linux* into
	#ifdef BFD64.

binutils-bfd64-mips-linux.diff
Index: binutils-fsf-trunk-quilt/bfd/config.bfd
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/config.bfd	2012-07-04 12:07:36.000000000 +0100
+++ binutils-fsf-trunk-quilt/bfd/config.bfd	2012-08-06 22:49:09.591194507 +0100
@@ -1005,7 +1005,6 @@ case "${targ}" in
     targ_selvecs="bfd_elf32_ntradlittlemips_vec bfd_elf32_tradbigmips_vec bfd_elf32_tradlittlemips_vec bfd_elf64_tradbigmips_vec bfd_elf64_tradlittlemips_vec"
     want64=true
     ;;
-#endif
   mips*el-*-linux*)
     targ_defvec=bfd_elf32_tradlittlemips_vec
     targ_selvecs="bfd_elf32_tradbigmips_vec ecoff_little_vec ecoff_big_vec bfd_elf32_ntradlittlemips_vec bfd_elf64_tradlittlemips_vec bfd_elf32_ntradbigmips_vec bfd_elf64_tradbigmips_vec"
@@ -1016,7 +1015,6 @@ case "${targ}" in
     targ_selvecs="bfd_elf32_tradlittlemips_vec ecoff_big_vec ecoff_little_vec bfd_elf32_ntradbigmips_vec bfd_elf64_tradbigmips_vec bfd_elf32_ntradlittlemips_vec bfd_elf64_tradlittlemips_vec"
     want64=true
     ;;
-#ifdef BFD64
   mips64*el-*-freebsd* | mips64*el-*-kfreebsd*-gnu)
     # FreeBSD vectors
     targ_defvec=bfd_elf32_ntradlittlemips_freebsd_vec

  reply	other threads:[~2012-08-10 11:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 15:22 Maciej W. Rozycki
2012-08-02 18:48 ` Richard Sandiford
2012-08-02 19:25   ` Maciej W. Rozycki
2012-08-04 18:32     ` Richard Sandiford
2012-08-06 21:45       ` Maciej W. Rozycki
2012-08-07  8:25         ` Richard Sandiford
2012-08-10 13:19           ` Maciej W. Rozycki [this message]
2012-08-12 18:34             ` Richard Sandiford
2012-08-13 15:21               ` Maciej W. Rozycki
2012-08-03  7:38 ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1208100248280.20608@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).