From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: <binutils@sourceware.org>
Subject: Re: [PATCH] MIPS/opcodes: Streamline disassembler's operand processing
Date: Tue, 14 Aug 2012 23:34:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1208142300170.20608@tp.orcam.me.uk> (raw)
In-Reply-To: <87pq6tuwkb.fsf@talisman.home>
On Tue, 14 Aug 2012, Richard Sandiford wrote:
> > * mips-dis.c (print_insn_args): Add GET_OP and GET_OP_S local
> > macros, use local variables for info struct member accesses,
> > update the type of the variable used to hold the instruction
> > word.
> > (print_insn_mips, print_mips16_insn_arg): Likewise.
> > (print_insn_mips16): Add GET_OP and GET_OP_S local macros, use
> > local variables for info struct member accesses.
> > (print_insn_micromips): Add GET_OP_S local macro.
> > (_print_insn_mips): Update the type of the variable used to hold
> > the instruction word.
>
> OK. Nice cleanup, thanks.
I've thought so. :) Applied now, thanks.
I'll be disappearing for two weeks now. When I'm back, I'll have a look
into some outstanding microMIPS stuff that you may remember discussing --
the controversial linker relaxation bits. I hope to get it cleaned up one
way or another, even if we find no better solution than discarding them
altogether.
Maciej
prev parent reply other threads:[~2012-08-14 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 0:54 Maciej W. Rozycki
2012-08-14 20:02 ` Richard Sandiford
2012-08-14 23:34 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1208142300170.20608@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).