From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21620 invoked by alias); 14 Aug 2012 22:11:41 -0000 Received: (qmail 21611 invoked by uid 22791); 14 Aug 2012 22:11:38 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Aug 2012 22:11:25 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1T1PKe-0000E0-ID from Maciej_Rozycki@mentor.com ; Tue, 14 Aug 2012 15:11:24 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 14 Aug 2012 15:11:24 -0700 Received: from [172.30.6.46] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 14 Aug 2012 23:11:21 +0100 Date: Tue, 14 Aug 2012 23:34:00 -0000 From: "Maciej W. Rozycki" To: Richard Sandiford CC: Subject: Re: [PATCH] MIPS/opcodes: Streamline disassembler's operand processing In-Reply-To: <87pq6tuwkb.fsf@talisman.home> Message-ID: References: <87pq6tuwkb.fsf@talisman.home> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00263.txt.bz2 On Tue, 14 Aug 2012, Richard Sandiford wrote: > > * mips-dis.c (print_insn_args): Add GET_OP and GET_OP_S local > > macros, use local variables for info struct member accesses, > > update the type of the variable used to hold the instruction > > word. > > (print_insn_mips, print_mips16_insn_arg): Likewise. > > (print_insn_mips16): Add GET_OP and GET_OP_S local macros, use > > local variables for info struct member accesses. > > (print_insn_micromips): Add GET_OP_S local macro. > > (_print_insn_mips): Update the type of the variable used to hold > > the instruction word. > > OK. Nice cleanup, thanks. I've thought so. :) Applied now, thanks. I'll be disappearing for two weeks now. When I'm back, I'll have a look into some outstanding microMIPS stuff that you may remember discussing -- the controversial linker relaxation bits. I hope to get it cleaned up one way or another, even if we find no better solution than discarding them altogether. Maciej