From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Nick Clifton <nickc@redhat.com>
Cc: <binutils@sourceware.org>
Subject: Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
Date: Fri, 06 May 2016 17:16:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1605061757550.6794@tp.orcam.me.uk> (raw)
In-Reply-To: <04428692-b013-06bd-d62e-67f79eff5446@redhat.com>
Hi Nick,
> > So does anybody actually know why the current per-architecture approach
> > was accepted in the review?
>
> No. My guess is that it was not thought through properly. Possibly a
> developer wanted it for their architecture, but did not consider the impact
> on other architectures. So their patch went in for their architecture and
> the feature proved to be useful. Then users for other architectures (probably
> kernel and library builders) decided that they wanted it too, and so a
> piecemeal set of hacks were added to accommodate them. Just a guess mind...
Thank you for your confirmation, I suspected this might have been the
case.
> > If not then I'll post a proposal separately to gather all the bits
> > scattered across target `*_add_symbol_hook' handlers and handle this
> > feature in `elf_link_add_object_symbols'.
>
> Please do.
I've got the test suite part done already, so I'll update code and post
the two changes together. I think it'll be the best if the code update
goes in first or both are a single change, so as not to cause regressions
which might break bisection.
Maciej
next prev parent reply other threads:[~2016-05-06 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 0:46 [PATCH 1/2] LD/testsuite: Add STB_GNU_UNIQUE cross-linker test Maciej W. Rozycki
2016-05-04 0:47 ` [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage Maciej W. Rozycki
2016-05-04 8:43 ` Matthew Fortune
2016-05-04 14:20 ` Maciej W. Rozycki
2016-05-04 15:55 ` Matthew Fortune
2016-05-04 16:54 ` Pedro Alves
2016-05-04 21:35 ` Maciej W. Rozycki
2016-05-06 16:43 ` Nick Clifton
2016-05-06 17:16 ` Maciej W. Rozycki [this message]
2016-05-04 11:19 ` [PATCH 1/2] LD/testsuite: Add STB_GNU_UNIQUE cross-linker test Nick Clifton
2016-05-04 14:32 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1605061757550.6794@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).