public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* hppa-linux-gnu-ranlib: libcpp.a: File format not recognized
@ 2016-12-22  5:14 Alan Modra
  2016-12-24  0:35 ` Maciej W. Rozycki
  0 siblings, 1 reply; 2+ messages in thread
From: Alan Modra @ 2016-12-22  5:14 UTC (permalink / raw)
  To: binutils
  Cc: Maciej W. Rozycki, Eric Christopher, Martin Schwidefsky, Andreas Krebbel

This stops an --enable-targets selection affecting the main target in
regards to forcing 64-bit archives.  It also means mips64 and s390x
will revert to binutils-2.25 and binutils-2.26 behaviour of not
forcing 64-bit archives at least in the common case when plugins were
enabled.

Since it appears no one even noticed the 2.25 and 2.26 behaviour on
mips and s390, I think it's safe to go back to creating the standard
archives on those targets.  They will still create 64-bit archives if
the size of their contents is too large for the 32-bit format.

	PR binutils/20464
	PR binutils/14625
	* configure.ac: Revert 2016-05-25 configure change setting
	want_64_bit_archive for mips64 and s390x.  Revise USE_64_BIT_ARCHIVE
	description.
	* configure: Regenerate.
	* config.in: Regenerate.

diff --git a/bfd/configure.ac b/bfd/configure.ac
index 3254dae..944fc56 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -786,20 +786,11 @@ else	# all_targets is true
     selarchs=`echo $selarchs | sed -e 's/^/\&/' -e 's/ \(.\)/,\&\1/g'`
 fi	# all_targets is true
 
-if test "x$want_64_bit_archive" = xunset; then
-  # 64-bit MIPS and s390 ELF targets use 64-bit archives.
-  case "${bfd_backends}" in
-    *elf64-mips* | *elf64-s390*)
-      want_64_bit_archive=true
-      ;;
-  esac
-fi
-
 # 64-bit archives need a 64-bit bfd_vma.
 if test "x$want_64_bit_archive" = xtrue; then
   want64=true
   AC_DEFINE(USE_64_BIT_ARCHIVE, 1,
-    [Define if we should use 64-bit archives.])
+    [Define if 64-bit archives should always be used.])
 fi
 
 case ${host64}-${target64}-${want64} in

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: hppa-linux-gnu-ranlib: libcpp.a: File format not recognized
  2016-12-22  5:14 hppa-linux-gnu-ranlib: libcpp.a: File format not recognized Alan Modra
@ 2016-12-24  0:35 ` Maciej W. Rozycki
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej W. Rozycki @ 2016-12-24  0:35 UTC (permalink / raw)
  To: Alan Modra
  Cc: binutils, Eric Christopher, Martin Schwidefsky, Andreas Krebbel

On Thu, 22 Dec 2016, Alan Modra wrote:

> This stops an --enable-targets selection affecting the main target in
> regards to forcing 64-bit archives.  It also means mips64 and s390x
> will revert to binutils-2.25 and binutils-2.26 behaviour of not
> forcing 64-bit archives at least in the common case when plugins were
> enabled.
> 
> Since it appears no one even noticed the 2.25 and 2.26 behaviour on
> mips and s390, I think it's safe to go back to creating the standard
> archives on those targets.  They will still create 64-bit archives if
> the size of their contents is too large for the 32-bit format.

 Ack.  This does sound reasonable to me if not obvious -- switching the 
archive format based solely on the list of configured targets regardless 
of the currently selected one or any explicit user action looks like a 
questionable approach to me to say the least.  Thanks for the fix.

  Maciej

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-24  0:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-22  5:14 hppa-linux-gnu-ranlib: libcpp.a: File format not recognized Alan Modra
2016-12-24  0:35 ` Maciej W. Rozycki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).