* [PATCH] MIPS/readelf: Remove extraneous null GOT data check
@ 2017-04-11 23:02 Maciej W. Rozycki
2017-04-12 7:24 ` Nick Clifton
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2017-04-11 23:02 UTC (permalink / raw)
To: Nick Clifton, binutils
Null data is handled gracefully throughout in MIPS GOT processing, with
addresses printed normally and unavailable data shown as `<unknown>' by
`print_mips_got_entry', and special processing code for GOT[1] doing an
explicit check. Remove an unwanted null GOT data check then, introduced
with commit 592458412fb2 in the course of addressing PR binutils/12855.
binutils/
* readelf.c (process_mips_specific): Remove null GOT data check.
---
No MIPS test case has been provided with PR binutils/12855, however this
is supposed to be obviously correct by means of proofreading the code
affected. I'll push it shortly then unless someone objects.
Maciej
binutils-mips-readelf-arch-got-data-null.diff
Index: binutils/binutils/readelf.c
===================================================================
--- binutils.orig/binutils/readelf.c 2017-04-10 23:13:23.156503246 +0100
+++ binutils/binutils/readelf.c 2017-04-10 23:34:46.430550614 +0100
@@ -15468,8 +15468,7 @@ process_mips_specific (FILE * file)
data = (unsigned char *) get_data (NULL, file, offset,
global_end - pltgot, 1,
_("Global Offset Table data"));
- if (data == NULL)
- return FALSE;
+ /* PR 12855: Null data is handled gracefully throughout. */
data_end = data + (global_end - pltgot);
printf (_("\nPrimary GOT:\n"));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/readelf: Remove extraneous null GOT data check
2017-04-11 23:02 [PATCH] MIPS/readelf: Remove extraneous null GOT data check Maciej W. Rozycki
@ 2017-04-12 7:24 ` Nick Clifton
2017-04-25 20:16 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2017-04-12 7:24 UTC (permalink / raw)
To: Maciej W. Rozycki, binutils
Hi Maciej,
> affected. I'll push it shortly then unless someone objects.
No objection - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/readelf: Remove extraneous null GOT data check
2017-04-12 7:24 ` Nick Clifton
@ 2017-04-25 20:16 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2017-04-25 20:16 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
On Wed, 12 Apr 2017, Nick Clifton wrote:
> > affected. I'll push it shortly then unless someone objects.
>
> No objection - please apply.
Committed.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-25 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 23:02 [PATCH] MIPS/readelf: Remove extraneous null GOT data check Maciej W. Rozycki
2017-04-12 7:24 ` Nick Clifton
2017-04-25 20:16 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).