From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30857 invoked by alias); 29 May 2014 17:57:56 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 30841 invoked by uid 89); 29 May 2014 17:57:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail7.parnet.fi Received: from mail7.parnet.fi (HELO mail7.parnet.fi) (77.234.108.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 29 May 2014 17:57:54 +0000 Received: from foo.martin.st (dyn-104-123.parnet.fi [77.234.104.123]) by mail7.parnet.fi (8.13.8/8.13.8) with ESMTP id s4THvkOM022641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 May 2014 20:57:47 +0300 Date: Thu, 29 May 2014 17:57:00 -0000 From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Yufeng Zhang cc: "binutils@sourceware.org" , Marcus Shawcroft Subject: Re: [PATCH] aarch64: Fix the documentation on :pg_hi21: In-Reply-To: <53875FE9.9080103@arm.com> Message-ID: References: <1401364824-4630-1-git-send-email-martin@martin.st> <538725B9.8060102@arm.com> <53875FE9.9080103@arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00273.txt.bz2 On Thu, 29 May 2014, Yufeng Zhang wrote: > On 05/29/14 13:19, Yufeng Zhang wrote: >> Hi Martin, >> >> On 05/29/14 13:00, Martin Storsjo wrote: >>> The syntax described, including a leading '#', was not supported >>> in practice. (For :lo12: it is optional.) >> >> I believe this is an issue in the parser; '#' should be optional in >> either case. >> >> It looks like gas/config/tc-aarch64.c:parse_adrp () is missing the >> skip_past_char (&p, '#') at its beginning; see parse_half () for an >> example. > > After spending some time this afternoon reading ARMv8 Architecture Reference > Manual (ARMARM) and having a discussion with a colleague, I think I'll have > to take back what I just said. Sorry! > > The A64 assembly language allows the optional # character to introduce > constant immediate operands, e.g. in LDR instructions with immediate offset: > > LDR , [], # > > and in the bitfield move instructions: > > BFM , , #, # > > The ADRP instruction, however, has the following syntax: > > ADRP ,