From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25658 invoked by alias); 3 Jun 2014 20:20:50 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 25646 invoked by uid 89); 3 Jun 2014 20:20:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail7.parnet.fi Received: from mail7.parnet.fi (HELO mail7.parnet.fi) (77.234.108.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Jun 2014 20:20:40 +0000 Received: from foo.martin.st (dyn-104-123.parnet.fi [77.234.104.123]) by mail7.parnet.fi (8.13.8/8.13.8) with ESMTP id s53KKXv7006086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Jun 2014 23:20:33 +0300 Date: Tue, 03 Jun 2014 20:20:00 -0000 From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: binutils@sourceware.org cc: Marcus Shawcroft Subject: Re: [PATCH] aarch64: Fix the documentation on :pg_hi21: In-Reply-To: <1401737495-10944-1-git-send-email-martin@martin.st> Message-ID: References: <538C8006.4000807@arm.com> <1401737495-10944-1-git-send-email-martin@martin.st> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00027.txt.bz2 On Mon, 2 Jun 2014, Martin Storsjo wrote: > The syntax described, including a leading '#', was not supported > in practice. (For :lo12: it is optional.) > --- > Added a ChangeLog entry. > --- > gas/ChangeLog | 4 ++++ > gas/doc/c-aarch64.texi | 10 +++++----- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/gas/ChangeLog b/gas/ChangeLog > index 98186d3..911511e 100644 > --- a/gas/ChangeLog > +++ b/gas/ChangeLog > @@ -1,3 +1,7 @@ > +2014-06-02 Martin Storsjo > + > + * doc/c-aarch64.texi: Fix the documentation on :pg_hi21:. > + > 2014-05-22 Alan Modra > > * listing.c (listing_warning, listing_error): Add space after colon. > diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi > index cce4f61..3d84123 100644 > --- a/gas/doc/c-aarch64.texi > +++ b/gas/doc/c-aarch64.texi > @@ -186,24 +186,24 @@ For example to load the 48-bit absolute address of @var{foo} into x0: > @cindex ADRP, ADD, LDR/STR group relocations, AArch64 > Relocations for @samp{ADRP}, and @samp{ADD}, @samp{LDR} or @samp{STR} > instructions can be generated by prefixing the label with > -@samp{#:pg_hi21:} and @samp{#:lo12:} respectively. > +@samp{:pg_hi21:} and @samp{:lo12:} respectively. > > For example to use 33-bit (+/-4GB) pc-relative addressing to > load the address of @var{foo} into x0: > > @smallexample > - adrp x0, #:pg_hi21:foo > + adrp x0, :pg_hi21:foo > add x0, x0, #:lo12:foo > @end smallexample > > Or to load the value of @var{foo} into x0: > > @smallexample > - adrp x0, #:pg_hi21:foo > + adrp x0, :pg_hi21:foo > ldr x0, [x0, #:lo12:foo] > @end smallexample > > -Note that @samp{#:pg_hi21:} is optional. > +Note that @samp{:pg_hi21:} is optional. > > @smallexample > adrp x0, foo > @@ -212,7 +212,7 @@ Note that @samp{#:pg_hi21:} is optional. > is equivalent to > > @smallexample > - adrp x0, #:pg_hi21:foo > + adrp x0, :pg_hi21:foo > @end smallexample > > @node AArch64 Floating Point > -- > 1.8.5.2 (Apple Git-48) Can someone apply and push this one? It was approved by Marcus yesterday, but since I can't push it myself, the ChangeLog has gotten another conflicting entry now - so whoever applies it will have to fix it up. (I won't try to send a new resolved patch because someone else will probably touch the ChangeLog inbetween again, before someone gets to pushing it.) // Martin